Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [Noon] Add script generated template code #1164

Merged
merged 2 commits into from
May 16, 2023
Merged

feat(connector): [Noon] Add script generated template code #1164

merged 2 commits into from
May 16, 2023

Conversation

SamraatBansal
Copy link
Contributor

@SamraatBansal SamraatBansal commented May 15, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Add the base code generated by script for Noon with test base url.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@SamraatBansal SamraatBansal requested review from a team as code owners May 15, 2023 12:10
@SamraatBansal SamraatBansal self-assigned this May 15, 2023
@SamraatBansal SamraatBansal added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 Review: Waiting on L1 reviewer labels May 15, 2023
@SamraatBansal SamraatBansal changed the title feat(connector): [Noon] Add script generated base code feat(connector): [Noon] Add script generated template code May 15, 2023
@jagan-jaya jagan-jaya added R-L1-completed Review: L1 Review completed and removed R-waiting-on-L1 Review: Waiting on L1 reviewer labels May 15, 2023
@jagan-jaya jagan-jaya added this to the May 2023 Release milestone May 15, 2023
@jagan-jaya jagan-jaya added R-waiting-on-L2 Review: Waiting on L2 reviewer S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L2 Review: Waiting on L2 reviewer R-L1-completed Review: L1 Review completed labels May 16, 2023
@jagan-jaya jagan-jaya enabled auto-merge May 16, 2023 08:01
@jagan-jaya jagan-jaya changed the title feat(connector): [Noon] Add script generated template code feat(connector): [Noon] Add script generated template code May 16, 2023
@jagan-jaya jagan-jaya requested a review from jarnura May 16, 2023 09:10
@jagan-jaya jagan-jaya added this pull request to the merge queue May 16, 2023
Merged via the queue into main with commit bfaf75f May 16, 2023
@SanchithHegde SanchithHegde deleted the noon-integ-scriptcode branch May 16, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarnura jarnura jarnura approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

@jagan-jaya jagan-jaya jagan-jaya approved these changes

Assignees

@SamraatBansal SamraatBansal

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
May 2023 Release
Development

Successfully merging this pull request may close these issues.
5 participants
@SamraatBansal @jagan-jaya @ArjunKarthik @jarnura @SanchithHegde