Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(connector): update error handling for Paypal, Checkout, Mollie to include detailed messages #1150

Merged
merged 8 commits into from
May 16, 2023
Merged

refactor(connector): update error handling for Paypal, Checkout, Mollie to include detailed messages #1150

merged 8 commits into from
May 16, 2023

Conversation

prasunna09
Copy link
Contributor

@prasunna09 prasunna09 commented May 12, 2023 •
edited by SanchithHegde
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Modified error message from dynamic to static messages. Also modified the tests accordingly.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Screenshot 2023-05-12 at 3 11 12 PM Screenshot 2023-05-12 at 3 12 06 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@prasunna09 prasunna09 added A-connector-integration Area: Connector integration S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor labels May 12, 2023
@prasunna09 prasunna09 self-assigned this May 12, 2023
@prasunna09 prasunna09 requested review from a team as code owners May 12, 2023 11:31
SanchithHegde
SanchithHegde reviewed May 12, 2023
View reviewed changes
crates/router/src/connector/checkout.rs Outdated Show resolved Hide resolved
crates/router/tests/connectors/checkout.rs Show resolved Hide resolved
crates/router/tests/connectors/paypal.rs Show resolved Hide resolved
crates/router/src/connector/paypal.rs Outdated Show resolved Hide resolved
crates/router/src/connector/paypal.rs Outdated Show resolved Hide resolved
@SanchithHegde SanchithHegde added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 12, 2023
@SanchithHegde SanchithHegde changed the title refactor(connector) : modified error message in error handling for Paypal, Checkout, Mollie refactor(connector): update error handling for Paypal, Checkout, Mollie to include detailed messages May 12, 2023
jagan-jaya
jagan-jaya requested changes May 13, 2023
View reviewed changes
crates/router/tests/connectors/paypal.rs Show resolved Hide resolved
crates/router/tests/connectors/paypal.rs Show resolved Hide resolved
crates/router/tests/connectors/paypal.rs Show resolved Hide resolved
crates/router/tests/connectors/paypal.rs Show resolved Hide resolved
crates/router/tests/connectors/paypal.rs Show resolved Hide resolved
crates/router/tests/connectors/paypal.rs Outdated Show resolved Hide resolved
@prasunna09 prasunna09 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels May 15, 2023
SanchithHegde
SanchithHegde previously approved these changes May 15, 2023
View reviewed changes
@jagan-jaya jagan-jaya added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 15, 2023
@jagan-jaya jagan-jaya added this to the May 2023 Release milestone May 16, 2023
@jagan-jaya jagan-jaya added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L2 Review: Waiting on L2 reviewer R-L1-completed Review: L1 Review completed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels May 16, 2023
@jagan-jaya jagan-jaya added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L2 Review: Waiting on L2 reviewer R-L1-completed Review: L1 Review completed labels May 16, 2023
@jagan-jaya jagan-jaya added this pull request to the merge queue May 16, 2023
Merged via the queue into main with commit e044c2f May 16, 2023
@SanchithHegde SanchithHegde deleted the fix-error-handling branch May 16, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

@jagan-jaya jagan-jaya jagan-jaya approved these changes

@jarnura jarnura Awaiting requested review from jarnura

Assignees

@prasunna09 prasunna09

Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
May 2023 Release
Development

Successfully merging this pull request may close these issues.
4 participants
@prasunna09 @jagan-jaya @ArjunKarthik @SanchithHegde