Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): add API route set_config #1144

Merged
merged 2 commits into from
May 15, 2023
Merged

feat(config): add API route set_config #1144

merged 2 commits into from
May 15, 2023

Conversation

NishantJoshi00
Copy link
Member

@NishantJoshi00 NishantJoshi00 commented May 11, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Adding an API route to provide ways to add keys and values in database/cache.
Currently, we only have exposed retrieve_config and read_config as possible paths.

Additional Changes

  • This PR modifies the API contract
    adding POST /config
    payload: { key: String, value: String }

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@NishantJoshi00 NishantJoshi00 added A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed M-api-contract-changes Metadata: This PR involves API contract changes R-waiting-on-L1 Review: Waiting on L1 reviewer labels May 11, 2023
@NishantJoshi00 NishantJoshi00 added this to the May 2023 Release milestone May 11, 2023
@NishantJoshi00 NishantJoshi00 self-assigned this May 11, 2023
@NishantJoshi00 NishantJoshi00 requested review from a team as code owners May 11, 2023 22:39
@NishantJoshi00 NishantJoshi00 mentioned this pull request May 11, 2023
Closed
2 tasks
@NishantJoshi00 NishantJoshi00 linked an issue May 11, 2023 that may be closed by this pull request
[FEATURE] add set_config route the the configs API #1145
Closed
2 tasks
SanchithHegde
SanchithHegde previously approved these changes May 12, 2023
View reviewed changes
@SanchithHegde SanchithHegde added R-waiting-on-L2 Review: Waiting on L2 reviewer R-L1-completed Review: L1 Review completed and removed R-waiting-on-L1 Review: Waiting on L1 reviewer labels May 12, 2023
dracarys18
dracarys18 previously approved these changes May 12, 2023
View reviewed changes
jarnura
jarnura previously approved these changes May 12, 2023
View reviewed changes
@jarnura jarnura added this pull request to the merge queue May 12, 2023
@jarnura jarnura added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L2 Review: Waiting on L2 reviewer labels May 12, 2023
@SanchithHegde SanchithHegde removed this pull request from the merge queue due to a manual request May 12, 2023
@SanchithHegde SanchithHegde changed the title fix(config): add API route set_config feat(config): add API route set_config May 12, 2023
@SanchithHegde SanchithHegde added the C-feature Category: Feature request or enhancement label May 12, 2023
@SanchithHegde SanchithHegde added this pull request to the merge queue May 12, 2023
@SanchithHegde SanchithHegde removed this pull request from the merge queue due to a manual request May 12, 2023
@SanchithHegde SanchithHegde added this pull request to the merge queue May 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 13, 2023
@SanchithHegde SanchithHegde added this pull request to the merge queue May 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch May 13, 2023
@SanchithHegde SanchithHegde added S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author and removed R-L1-completed Review: L1 Review completed labels May 13, 2023
@SanchithHegde SanchithHegde added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author labels May 15, 2023
@SanchithHegde SanchithHegde added this pull request to the merge queue May 15, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 15, 2023
@SanchithHegde SanchithHegde added this pull request to the merge queue May 15, 2023
Merged via the queue into main with commit f31926b May 15, 2023
@SanchithHegde SanchithHegde deleted the feat/set-config branch May 15, 2023 10:32
@SanchithHegde SanchithHegde removed S-ready-for-merge S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sai-harsha-vardhan sai-harsha-vardhan sai-harsha-vardhan approved these changes

@dracarys18 dracarys18 dracarys18 approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@jarnura jarnura jarnura left review comments

Assignees

@NishantJoshi00 NishantJoshi00

Labels
A-core Area: Core flows C-feature Category: Feature request or enhancement M-api-contract-changes Metadata: This PR involves API contract changes
Projects
None yet
Milestone
May 2023 Release
Development

Successfully merging this pull request may close these issues.

[FEATURE] add set_config route the the configs API
5 participants
@NishantJoshi00 @jarnura @SanchithHegde @dracarys18 @sai-harsha-vardhan