-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(error): add feature-gated stacktrace to error received from API #1104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more request: Can we manage to un-escape the strings in the list of errors returned? It would be great if it can be done, it would improve readability by a great extent. Let me know if it involves too much effort and/or performance hits, I'll approve this PR.
Even when it's a string, don't you think it would improve readability if it's un-escaped? As for the performance hit, we're expecting to enable this for debug and/or testing builds, so I believe it is acceptable? |
Hey, this side effect of having escaped characters isn't because of my implementation is handling this behaviour, it's how it is being stored. That's what causing this issue |
Type of Change
Description
This change provides a feature-gated functionality for exporting the
stacktrace
in the API response, for easier debugging and faster RCAsAdditional Changes
This change only affects the outbound error response, adding a optional field
stacktrace
which is only provided when the specific feature is enabled.Motivation and Context
How did you test it?
via. postman
Checklist
cargo +nightly fmt --all
cargo clippy