feat(router): add route to invalidate cache entry #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeevaprakashdr
force-pushed
the
feature_995_add_route_to_invalidate_cache
branch
5 times, most recently
from
ff92f9c
to
0850a4f
Compare
SanchithHegde
added
A-framework
SanchithHegde
added
S-waiting-on-author
SanchithHegde
changed the title
Narayanbhat166
changed the title
jeevaprakashdr
force-pushed
the
feature_995_add_route_to_invalidate_cache
branch
from
2f1974c
to
f0d6624
Compare
added remove method to invalidate the cache key
added endpont added unit test
refactored route to include route parameters Added flow type Added API error response type Created cache interface for db module updated unit test: Check if the key/value is invalidated.
remove dthe cache interface
SanchithHegde
previously approved these changes
Jun 3, 2023
dracarys18
reviewed
Jun 12, 2023
# Conflicts: # Cargo.lock
dracarys18
previously approved these changes
Jun 13, 2023
SanchithHegde
previously approved these changes
Jun 13, 2023
SanchithHegde
added
S-waiting-on-review
dracarys18
reviewed
Jun 13, 2023
# Conflicts: # crates/router_env/src/logger/types.rs
jeevaprakashdr
dismissed stale reviews from SanchithHegde and dracarys18
via
3e5736a
dracarys18
approved these changes
Jun 21, 2023
SanchithHegde
approved these changes
Jun 21, 2023
SanchithHegde
added
S-ready-for-merge
and removed
S-waiting-on-review
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
A new route to invalidate the in-memory cache and redis
Additional Changes
Motivation and Context
Currently we don't have any way to manually invalidate cache that's stored in redis and in-memory,
Closes #995.
How did you test it?
A unit test is added to test the in-memory cache and postman script used for redis cache.
Checklist
cargo +nightly fmt --allcargo clippy