Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(router): add id field in MerchantConnectorAccountNotFound #1098

Merged
merged 2 commits into from
May 10, 2023
Merged

refactor(router): add id field in MerchantConnectorAccountNotFound #1098

merged 2 commits into from
May 10, 2023

Conversation

EliKalter
Copy link
Contributor

@EliKalter EliKalter commented May 9, 2023 •
edited by SanchithHegde
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Add id field to MerchantConnectorAccountNotFound,
Send connector_label when possible,
Send merchant_connector_id otherwise,
Change create_payment_connector function to raise InternalServerError instead of MerchantConnectorAccountNotFound

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Fixes #1053

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@EliKalter EliKalter requested review from a team as code owners May 9, 2023 17:17
@SanchithHegde SanchithHegde added A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor M-api-contract-changes Metadata: This PR involves API contract changes labels May 9, 2023
SanchithHegde
SanchithHegde approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @EliKalter!

@jarnura jarnura added this pull request to the merge queue May 10, 2023
@jarnura jarnura added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 10, 2023
Merged via the queue into juspay:main with commit 5214e22 May 10, 2023
@Narayanbhat166
Copy link
Member

Thanks for the contribution @EliKalter. Cheers 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@jarnura jarnura jarnura approved these changes

@Narayanbhat166 Narayanbhat166 Awaiting requested review from Narayanbhat166

@NishantJoshi00 NishantJoshi00 Awaiting requested review from NishantJoshi00

Assignees

@EliKalter EliKalter

Labels
A-core Area: Core flows C-refactor Category: Refactor M-api-contract-changes Metadata: This PR involves API contract changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Add id field in MerchantConnectorAccountNotFound error type
4 participants
@EliKalter @Narayanbhat166 @jarnura @SanchithHegde