Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): Remove ui tests from ci pipeline #1082

Merged
merged 5 commits into from
May 9, 2023
Merged

Conversation

jagan-jaya
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Remove ui tests from ci pipeline

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code

@jagan-jaya jagan-jaya added the C-bug Category: Bug label May 8, 2023
@jagan-jaya jagan-jaya requested a review from jarnura May 8, 2023 21:57
@jagan-jaya jagan-jaya self-assigned this May 8, 2023
@jagan-jaya jagan-jaya added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label May 9, 2023
@SanchithHegde
Copy link
Member

A possible better solution would be to limit the tests run by updating the filter to include the module name followed by ::?

So, in this step:

- name: Run connector tests
uses: actions-rs/cargo@v1
with:
command: test
args: --package router --test connectors -- ${{ matrix.connector }} --test-threads=1

If you updated the filter to be ${{ matrix.connector }}::, it would run those tests where the module name matches those enabled in the CI workflow.

@SanchithHegde SanchithHegde added A-CI-CD Area: Continuous Integration/Deployment A-connector-integration Area: Connector integration S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 9, 2023
@jagan-jaya jagan-jaya requested review from a team as code owners May 9, 2023 19:35
@jagan-jaya jagan-jaya added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels May 9, 2023
@jarnura jarnura added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 9, 2023
@SanchithHegde SanchithHegde added this pull request to the merge queue May 9, 2023
Merged via the queue into main with commit 2ab7f83 May 9, 2023
@SanchithHegde SanchithHegde deleted the fix-stripe-tests branch May 9, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI-CD Area: Continuous Integration/Deployment A-connector-integration Area: Connector integration C-bug Category: Bug
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

3 participants