fix(router): fix recursion bug in straight through algorithm #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vspecky
added
A-core
NishantJoshi00
approved these changes
May 9, 2023
SanchithHegde
approved these changes
May 9, 2023
ashokkjag
approved these changes
May 9, 2023
SanchithHegde
removed
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Usage of an inner enum type for serialization and deserialization of the straight through routing algorithm in the payments request.
Additional Changes
None
Motivation and Context
This PR fixes an infinite recursion bug in deserialization of the straight through routing algorithm in the payments request.
How did you test it?
Local testing, test recursion edge case locally.
Checklist
cargo +nightly fmt --allcargo clippy