Feat(Connector): [ACI] Implement Przelewy24 Bank Redirect #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakilmostak
added
A-connector-integration
ArjunKarthik
requested changes
May 8, 2023
crates/api_models/src/payments.rs
Outdated
| Przelewy24 {}, | ||
| Przelewy24 { | ||
| // Shopper Email | ||
| email: Option<Email>, |
There was a problem hiding this comment.
You can remove option for the email as earlier we don't know what could be the data needed for this payment method.
ArjunKarthik
added
S-waiting-on-author
Sakilmostak
changed the title
jagan-jaya
approved these changes
May 10, 2023
jagan-jaya
approved these changes
May 10, 2023
jagan-jaya
added
R-waiting-on-L2
ArjunKarthik
approved these changes
May 10, 2023
ArjunKarthik
added
R-waiting-on-L1
jarnura
approved these changes
May 10, 2023
jarnura
added
S-ready-for-merge
and removed
R-waiting-on-L2
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
SanchithHegde
removed
R-L1-completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Implemented Przelewy24 Bank Redirect for ACI
Additional Changes
Motivation and Context
In ACI connector Przelewy24 Bank Redirect was not implemented, but it is important payment method which is needed in market so I implemented it.
How did you test it?
I tested it using postman
Checklist
cargo +nightly fmt --allcargo clippy