Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(redis): fix recreation on redis connection pool #1063

Merged
merged 1 commit into from
May 8, 2023
Merged

fix(redis): fix recreation on redis connection pool #1063

merged 1 commit into from
May 8, 2023

Conversation

NishantJoshi00
Copy link
Member

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR fixes the issue of creating multiple Redis connection pool everywhere. It provides a trait to access the interior redis connection pool.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Fixes redis connection pool, and stabilises #1051

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@NishantJoshi00 NishantJoshi00 added A-framework Area: Framework A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 Review: Waiting on L1 reviewer labels May 8, 2023
@NishantJoshi00 NishantJoshi00 self-assigned this May 8, 2023
@NishantJoshi00 NishantJoshi00 requested review from a team, jarnura and ashokkjag as code owners May 8, 2023 08:04
@dracarys18 dracarys18 added R-L1-completed Review: L1 Review completed and removed R-waiting-on-L1 Review: Waiting on L1 reviewer labels May 8, 2023
@NishantJoshi00 NishantJoshi00 added the R-waiting-on-L2 Review: Waiting on L2 reviewer label May 8, 2023
@jarnura jarnura removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L2 Review: Waiting on L2 reviewer labels May 8, 2023
@jarnura jarnura merged commit 982c27f into main May 8, 2023
@jarnura jarnura deleted the redis-conn-interface branch May 8, 2023 09:01
@SanchithHegde SanchithHegde added C-bug Category: Bug and removed R-L1-completed Review: L1 Review completed labels May 8, 2023
@SamraatBansal SamraatBansal mentioned this pull request May 8, 2023
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@dracarys18 dracarys18 dracarys18 approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@jarnura jarnura jarnura approved these changes

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

Assignees

@NishantJoshi00 NishantJoshi00

Labels
A-core Area: Core flows A-framework Area: Framework C-bug Category: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NishantJoshi00 @jarnura @SanchithHegde @dracarys18 @Narayanbhat166