Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(refunds): add connector field in refund response #1059

Merged
merged 2 commits into from
May 9, 2023
Merged

feat(refunds): add connector field in refund response #1059

merged 2 commits into from
May 9, 2023

Conversation

Abhicodes-crypto
Copy link
Contributor

@Abhicodes-crypto Abhicodes-crypto commented May 5, 2023 •
edited by Sarthak1799
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added connector field in refund response. We have connector field in storage model of Refund but don't return it in Refund response. Add it in refund response gives context as to which connector was called for refund(same connector through which payment was made).

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

address #1058

How did you test it?

@Sarthak1799 tested it.
Getting the connector field in refund response as expected.
image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Abhicodes-crypto Abhicodes-crypto self-assigned this May 5, 2023
@Abhicodes-crypto Abhicodes-crypto requested review from a team as code owners May 5, 2023 13:50
@Abhicodes-crypto Abhicodes-crypto added C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed A-core Area: Core flows M-api-contract-changes Metadata: This PR involves API contract changes labels May 5, 2023
@SanchithHegde SanchithHegde changed the title enhan(refunds): add connector field in refund response feat(refunds): add connector field in refund response May 5, 2023
@Narayanbhat166
Copy link
Member

Can you post a screenshot of the tests that were made in postman?

@Abhicodes-crypto Abhicodes-crypto added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 9, 2023
@jarnura jarnura closed this May 9, 2023
@jarnura jarnura reopened this May 9, 2023
@jarnura jarnura enabled auto-merge May 9, 2023 14:19
@jarnura jarnura added this pull request to the merge queue May 9, 2023
Merged via the queue into main with commit 3fe24b3 May 9, 2023
@SanchithHegde SanchithHegde deleted the add-connector-refund-resp branch May 9, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashokkjag ashokkjag ashokkjag approved these changes

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@Abhicodes-crypto Abhicodes-crypto

Labels
A-core Area: Core flows C-feature Category: Feature request or enhancement M-api-contract-changes Metadata: This PR involves API contract changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Abhicodes-crypto @Narayanbhat166 @SanchithHegde @ashokkjag @jarnura @Sarthak1799