refactor: use strum::EnumString implementation for connector name conversions
#1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nachiketkanore Could you comment on #1042 that you've taken it up? Please ensure that you do so for any further issues that you take up. |
…efactor # Conflicts: # crates/router/src/types/api.rs
jarnura
previously approved these changes
May 4, 2023
jarnura
added
the
S-waiting-on-review
NishantJoshi00
previously approved these changes
May 5, 2023
SanchithHegde
added
S-waiting-on-author
…efactor # Conflicts: # crates/router/src/types/api.rs
SanchithHegde
added
S-design
nachiketkanore
dismissed stale reviews from NishantJoshi00 and jarnura
via
c158e04
jarnura
previously approved these changes
May 16, 2023
SanchithHegde
previously approved these changes
May 17, 2023
There was a problem hiding this comment.
Thanks for the PR, @nachiketkanore!
@jagan-jaya The add_connector script will have to be updated to accommodate this change. I feel it's best we have it as a separate PR.
jarnura
added
S-ready-for-merge
and removed
S-waiting-on-review
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
2 tasks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
… strum-from-string-refactor
auto-merge was automatically disabled
May 18, 2023 12:56
Head branch was pushed to by a user without write access
nachiketkanore
dismissed stale reviews from SanchithHegde and jarnura
via
a51b50a
SanchithHegde
approved these changes
May 18, 2023
jarnura
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
from_strfunction of strum #1042Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy