Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Connector): [Stripe] Implemented Alipay Digital Wallet #1048

Merged
merged 9 commits into from
May 9, 2023
Merged

feat(Connector): [Stripe] Implemented Alipay Digital Wallet #1048

merged 9 commits into from
May 9, 2023

Conversation

AkshayaFoiger
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Implemented Alipay digital wallet, payment method for Stripe.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

In Stripe connector Alipay was not implemented, but it is important payment method which is needed in market so I implemented it.

How did you test it?

I tested it using Postman
Screenshot 2023-05-04 at 12 53 21 PM
Screenshot 2023-05-04 at 12 54 03 PM
Screenshot 2023-05-04 at 2 04 38 PM
Screenshot 2023-05-04 at 2 01 16 PM

Checklist

  • [x ] I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@AkshayaFoiger AkshayaFoiger added A-connector-compatibility Area: Connector compatibility R-waiting-on-L1 Review: Waiting on L1 reviewer labels May 4, 2023
@AkshayaFoiger AkshayaFoiger requested review from a team, jarnura and ashokkjag as code owners May 4, 2023 08:43
@AkshayaFoiger AkshayaFoiger added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement and removed A-connector-compatibility Area: Connector compatibility labels May 5, 2023
jagan-jaya
jagan-jaya previously approved these changes May 5, 2023
View reviewed changes
@jagan-jaya jagan-jaya added R-waiting-on-L2 Review: Waiting on L2 reviewer and removed R-waiting-on-L1 Review: Waiting on L1 reviewer labels May 5, 2023
ArjunKarthik
ArjunKarthik previously approved these changes May 8, 2023
View reviewed changes
@ArjunKarthik ArjunKarthik added the R-L1-completed Review: L1 Review completed label May 8, 2023
@AkshayaFoiger AkshayaFoiger changed the title feat(Connector): Implemented Alipay for Stripe feat(Connector): [Stripe] Implemented Alipay May 8, 2023
@AkshayaFoiger AkshayaFoiger changed the title feat(Connector): [Stripe] Implemented Alipay feat(Connector): [Stripe] Implemented Alipay Digital Wallet May 8, 2023
jarnura
jarnura previously approved these changes May 9, 2023
View reviewed changes
@jarnura jarnura added S-waiting-on-author Status: This PR is incomplete or needs to address review comments S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author and removed R-waiting-on-L2 Review: Waiting on L2 reviewer labels May 9, 2023
@jagan-jaya jagan-jaya dismissed stale reviews from ArjunKarthik and themself via f52c1ea May 9, 2023 18:07
@jagan-jaya jagan-jaya added S-ready-for-merge and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author labels May 9, 2023
@jarnura jarnura added this pull request to the merge queue May 9, 2023
Merged via the queue into main with commit 7c7185b May 9, 2023
@SanchithHegde SanchithHegde removed R-L1-completed Review: L1 Review completed S-ready-for-merge labels May 9, 2023
@SanchithHegde SanchithHegde deleted the alipay branch May 9, 2023 18:51
@SanchithHegde SanchithHegde mentioned this pull request May 17, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarnura jarnura jarnura approved these changes

@jagan-jaya jagan-jaya jagan-jaya approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik left review comments

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

Assignees

@AkshayaFoiger AkshayaFoiger

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AkshayaFoiger @jagan-jaya @ArjunKarthik @jarnura @SanchithHegde