refactor(router): add the connector_label field to DuplicateMerchantConnectorAccount error message
#1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanchithHegde
added
A-core
SanchithHegde
added
S-waiting-on-review
EliKalter
changed the title
SanchithHegde
changed the title
connector_label field to DuplicateMerchantConnectorAccount error message
jarnura
approved these changes
May 4, 2023
jarnura
added
S-ready-for-merge
and removed
S-waiting-on-review
Narayanbhat166
approved these changes
May 4, 2023
There was a problem hiding this comment.
Looks Good. Thanks for the contribution @EliKalter. You can also add this field to MerchantConnectorNotFound error message.
If interested, please create an issue and take it up in a separate PR.
Cheers.
I'll do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR adds the connector_label to the message of the DuplicateMerchantConnectorAccount variant in the ApiErrorResponse enum
Additional Changes
Motivation and Context
This resolves #899,
The connector_label is created by Hyperswitch internally hence it is necessary to send back the connector_label is the error response so that the user has an idea of what the connector_label is.
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy