Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(router): add disputes block in payments retrieve response #1038

Merged
merged 10 commits into from
May 9, 2023
Merged

feat(router): add disputes block in payments retrieve response #1038

merged 10 commits into from
May 9, 2023

Conversation

sai-harsha-vardhan
Copy link
Contributor

@sai-harsha-vardhan sai-harsha-vardhan commented May 3, 2023 •
edited by SanchithHegde
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

add disputes block in payments retrieve response

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested Manually
image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@sai-harsha-vardhan sai-harsha-vardhan added A-core Area: Core flows C-feature Category: Feature request or enhancement M-api-contract-changes Metadata: This PR involves API contract changes R-waiting-on-L1 Review: Waiting on L1 reviewer labels May 3, 2023
@sai-harsha-vardhan sai-harsha-vardhan self-assigned this May 3, 2023
@sai-harsha-vardhan sai-harsha-vardhan requested review from a team as code owners May 3, 2023 12:17
vspecky
vspecky previously approved these changes May 5, 2023
View reviewed changes
@sai-harsha-vardhan sai-harsha-vardhan added R-waiting-on-L2 Review: Waiting on L2 reviewer and removed R-waiting-on-L1 Review: Waiting on L1 reviewer labels May 5, 2023
SanchithHegde
SanchithHegde reviewed May 5, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, looks good to me!

crates/api_models/src/disputes.rs Show resolved Hide resolved
crates/api_models/src/disputes.rs Outdated Show resolved Hide resolved
crates/router/src/core/payments/operations/payment_status.rs Outdated Show resolved Hide resolved
@SanchithHegde SanchithHegde added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed R-waiting-on-L2 Review: Waiting on L2 reviewer labels May 5, 2023
@sai-harsha-vardhan sai-harsha-vardhan added R-waiting-on-L2 Review: Waiting on L2 reviewer and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels May 6, 2023
@sai-harsha-vardhan sai-harsha-vardhan added the M-database-changes Metadata: This PR involves database schema changes label May 8, 2023
SanchithHegde
SanchithHegde previously approved these changes May 8, 2023
View reviewed changes
vspecky
vspecky previously approved these changes May 9, 2023
View reviewed changes
@sai-harsha-vardhan sai-harsha-vardhan added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed R-waiting-on-L2 Review: Waiting on L2 reviewer labels May 9, 2023
jarnura
jarnura previously approved these changes May 9, 2023
View reviewed changes
@jarnura jarnura added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 9, 2023
@jarnura jarnura added this to the May 2023 Release milestone May 9, 2023
@jarnura jarnura added this pull request to the merge queue May 9, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch May 9, 2023
@SanchithHegde SanchithHegde added this pull request to the merge queue May 9, 2023
Merged via the queue into main with commit 1304d91 May 9, 2023
@SanchithHegde SanchithHegde deleted the add_disputes_retrieve_intent branch May 9, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@jarnura jarnura jarnura approved these changes

@Narayanbhat166 Narayanbhat166 Awaiting requested review from Narayanbhat166

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

@vspecky vspecky Awaiting requested review from vspecky

Assignees

@sai-harsha-vardhan sai-harsha-vardhan

Labels
A-core Area: Core flows C-feature Category: Feature request or enhancement M-api-contract-changes Metadata: This PR involves API contract changes M-database-changes Metadata: This PR involves database schema changes
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
May 2023 Release
Development

Successfully merging this pull request may close these issues.
4 participants
@sai-harsha-vardhan @jarnura @SanchithHegde @vspecky