fix(mandate): make payment_method_data optional for mandate scenario #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagan-jaya
added
A-core
NishantJoshi00
requested changes
May 3, 2023
NishantJoshi00
previously approved these changes
May 4, 2023
Narayanbhat166
requested changes
May 4, 2023
| }; | ||
| if let storage_models::enums::PaymentMethod::Card = payment_method.payment_method { | ||
| let _ = | ||
| cards::get_lookup_key_from_locker(state, &token, &payment_method, &locker_id).await?; |
There was a problem hiding this comment.
@manoj-juspay Why is this call being made and then the value is dropped? Is this to get the card data from permanent locker to basilisk?
jarnura
previously approved these changes
May 4, 2023
jarnura
added
S-waiting-on-author
ArjunKarthik
requested changes
May 4, 2023
jagan-jaya
added
S-waiting-on-review
ArjunKarthik
approved these changes
May 6, 2023
jarnura
approved these changes
May 8, 2023
Narayanbhat166
approved these changes
May 8, 2023
jarnura
added
S-ready-for-merge
and removed
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
For Recurring mandate payments we don't need payment_method_data, currently we are storing all card_details in locker so payment_method_data can be built from card_details in locker for card_payment but in other_payment_methods(google_pay, apple_pay) it won't be possible, so we can ignore the payment_method_data in all recurring mandate payments.
Additional Changes
Motivation and Context
Closes #1011
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy