Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(README): remove redundant "more" in FAQs #1031

Merged
merged 1 commit into from
May 2, 2023
Merged

doc(README): remove redundant "more" in FAQs #1031

merged 1 commit into from
May 2, 2023

Conversation

EliKalter
Copy link
Contributor

@EliKalter EliKalter commented May 2, 2023 •
edited by SanchithHegde
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Removed duplicate "more" word from the FAQs section in the REDME.md file

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

There was a typo.

How did you test it?

No need for testing

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@EliKalter EliKalter requested a review from a team as a code owner May 2, 2023 17:53
@SanchithHegde SanchithHegde changed the title in REDME.md FAQs removed redundant 'more' doc(README): remove redundant "more" in FAQs May 2, 2023
@SanchithHegde SanchithHegde added C-doc Category: Documentation updates S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 2, 2023
SanchithHegde
SanchithHegde approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@jarnura jarnura removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label May 2, 2023
@jarnura jarnura merged commit 9cbda83 into juspay:main May 2, 2023
@EliKalter EliKalter deleted the fix_FAQs_double_more_typo branch May 3, 2023 04:42
@Narayanbhat166 Narayanbhat166 mentioned this pull request May 3, 2023
Closed
1 task
@NarsGNA
Copy link
Contributor

NarsGNA commented May 24, 2023

@EliKalter can you please share you LinkedIn and Twitter handle? Would love to give you a shoutout for your contributions

@EliKalter
Copy link
Contributor Author

@EliKalter can you please share you LinkedIn and Twitter handle? Would love to give you a shoutout for your contributions

I don't have LinkedIn nor do I have Twitter,
Thanks though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@jarnura jarnura jarnura approved these changes

Assignees

@EliKalter EliKalter

Labels
C-doc Category: Documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EliKalter @NarsGNA @jarnura @SanchithHegde