Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(compatibility): refactor stripe compatibility routes using web::resource #1022

Merged
merged 9 commits into from
May 4, 2023
Merged

refactor(compatibility): refactor stripe compatibility routes using web::resource #1022

merged 9 commits into from
May 4, 2023

Conversation

nachiketkanore
Copy link
Contributor

@nachiketkanore nachiketkanore commented Apr 28, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

  • run cargo check on the entire project
  • format the code

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@nachiketkanore nachiketkanore changed the title refactor stripe compatibility routes #961 refactor stripe compatibility routes Apr 28, 2023
SanchithHegde
SanchithHegde reviewed May 1, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, looks good to me!

crates/router/src/compatibility/stripe/customers.rs Outdated Show resolved Hide resolved
crates/router/src/compatibility/stripe/payment_intents.rs Outdated Show resolved Hide resolved
@Abhicodes-crypto Abhicodes-crypto changed the title refactor stripe compatibility routes refactor(compatibility): refactor stripe compatibility routes using web::resource May 2, 2023
@SanchithHegde SanchithHegde added A-connector-compatibility Area: Connector compatibility S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor labels May 3, 2023
Abhicodes-crypto
Abhicodes-crypto approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@Abhicodes-crypto Abhicodes-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the PR.

@jarnura jarnura removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label May 4, 2023
@jarnura jarnura added this pull request to the merge queue May 4, 2023
Merged via the queue into juspay:main with commit 92ae2d9 May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abhicodes-crypto Abhicodes-crypto Abhicodes-crypto approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@jarnura jarnura jarnura approved these changes

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

Assignees

@nachiketkanore nachiketkanore

Labels
A-connector-compatibility Area: Connector compatibility C-refactor Category: Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Refactor Stripe compatibility routes
4 participants
@nachiketkanore @jarnura @SanchithHegde @Abhicodes-crypto