Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): add dispute and refund webhooks for Airwallex #1021

Merged
merged 6 commits into from
May 9, 2023
Merged

feat(connector): add dispute and refund webhooks for Airwallex #1021

merged 6 commits into from
May 9, 2023

Conversation

ShankarSinghC
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Implemented Dispute and Refund Webhooks for Airwallex

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Dispute and Refund webhooks can not be tested, but the schema has been followed https://www.airwallex.com/docs/online-payments__disputes__dispute-notifications

Airwallex_test

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@ShankarSinghC ShankarSinghC added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Apr 28, 2023
@ShankarSinghC ShankarSinghC requested a review from a team as a code owner April 28, 2023 07:19
@ShankarSinghC ShankarSinghC self-assigned this Apr 28, 2023
ArjunKarthik
ArjunKarthik previously approved these changes May 1, 2023
View reviewed changes
sai-harsha-vardhan
sai-harsha-vardhan requested changes May 2, 2023
View reviewed changes
crates/router/src/connector/airwallex.rs Outdated Show resolved Hide resolved
crates/router/src/connector/airwallex.rs Outdated Show resolved Hide resolved
crates/router/src/connector/airwallex/transformers.rs Outdated Show resolved Hide resolved
@ArjunKarthik ArjunKarthik added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 3, 2023
@ShankarSinghC ShankarSinghC added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels May 4, 2023
sai-harsha-vardhan
sai-harsha-vardhan approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@sai-harsha-vardhan sai-harsha-vardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jagan-jaya jagan-jaya added the R-waiting-on-L2 Review: Waiting on L2 reviewer label May 5, 2023
@jagan-jaya jagan-jaya added this to the May 2023 Release milestone May 5, 2023
@jarnura jarnura enabled auto-merge May 9, 2023 14:22
@jarnura jarnura added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L2 Review: Waiting on L2 reviewer labels May 9, 2023
@jarnura jarnura added this pull request to the merge queue May 9, 2023
Merged via the queue into main with commit 8c34114 May 9, 2023
@SanchithHegde SanchithHegde deleted the airwallex_disputes branch May 9, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sai-harsha-vardhan sai-harsha-vardhan sai-harsha-vardhan approved these changes

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@jarnura jarnura jarnura approved these changes

@jagan-jaya jagan-jaya jagan-jaya approved these changes

@SamraatBansal SamraatBansal Awaiting requested review from SamraatBansal

@ArjunKarthik ArjunKarthik Awaiting requested review from ArjunKarthik

Assignees

@ShankarSinghC ShankarSinghC

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
May 2023 Release
Development

Successfully merging this pull request may close these issues.
7 participants
@ShankarSinghC @jagan-jaya @ArjunKarthik @jarnura @Narayanbhat166 @sai-harsha-vardhan @SanchithHegde