-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(config): add independent toggles for enabling traces and metrics #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanchithHegde
added
A-framework
Area: Framework
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
M-configuration-changes
Metadata: This PR involves configuration changes
C-refactor
Category: Refactor
labels
Apr 28, 2023
SanchithHegde
requested review from
a team,
jarnura and
ashokkjag
as code owners
April 28, 2023 07:01
Abhicodes-crypto
previously approved these changes
Apr 28, 2023
lsampras
reviewed
May 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lsampras
approved these changes
May 2, 2023
SanchithHegde
added
R-waiting-on-L2
Review: Waiting on L2 reviewer
R-L1-completed
Review: L1 Review completed
labels
May 2, 2023
Abhicodes-crypto
approved these changes
May 2, 2023
jarnura
approved these changes
May 2, 2023
jarnura
added
S-ready-for-merge
and removed
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
R-waiting-on-L2
Review: Waiting on L2 reviewer
labels
May 2, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
May 3, 2023
SanchithHegde
removed
R-L1-completed
Review: L1 Review completed
S-ready-for-merge
labels
May 3, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-framework
Area: Framework
C-refactor
Category: Refactor
M-configuration-changes
Metadata: This PR involves configuration changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR adds two configuration variables for toggling traces and metrics independently instead of using a single toggle to enable both. In addition, this PR introduces one more configuration variable to ignore errors during traces and metrics setup, if required.
Additional Changes
The
log.telemetry.enabled
configuration variable is no longer being used, thelog.telemetry.traces_enabled
andlog.telemetry.metrics_enabled
configuration variables must be used instead for toggling traces and metrics, respectively. In addition, errors during traces or metrics setup can be ignored using thelog.telemetry.ignore_errors
configuration variable.Motivation and Context
This would allow us to have metrics and traces independently enabled, as required.
How did you test it?
Manually.
Checklist
cargo +nightly fmt --all
cargo clippy