Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update API response for JSON deserialization errors #6610

Merged
merged 7 commits into from
Nov 21, 2024

Conversation

kashif-m
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Described in #6609

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Locally.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@kashif-m kashif-m requested a review from a team as a code owner November 19, 2024 11:05
Copy link

semanticdiff-com bot commented Nov 19, 2024

@kashif-m kashif-m self-assigned this Nov 19, 2024
dracarys18
dracarys18 previously approved these changes Nov 19, 2024
srujanchikke
srujanchikke previously approved these changes Nov 20, 2024
@kashif-m kashif-m requested a review from a team as a code owner November 20, 2024 09:10
dracarys18
dracarys18 previously approved these changes Nov 20, 2024
pixincreate
pixincreate previously approved these changes Nov 21, 2024
Copy link
Member

@pixincreate pixincreate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cypress changes, looks good.

dracarys18
dracarys18 previously approved these changes Nov 21, 2024
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Nov 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 21, 2024
@SanchithHegde SanchithHegde added this pull request to the merge queue Nov 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 21, 2024
@SanchithHegde SanchithHegde added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit 40d3c38 Nov 21, 2024
16 of 17 checks passed
@SanchithHegde SanchithHegde deleted the 6609-json-deserial-errors branch November 21, 2024 22:26
pixincreate added a commit that referenced this pull request Nov 22, 2024
…ed-cypress

* 'main' of github.com:juspay/hyperswitch:
  fix(connector): [Cybersource] change commerce indicator for applepay (#6634)
  ci(cypress): Add Noon Connector (#6603)
  fix(analytics): remove first_attempt group by in Payment Intent old metrics (#6627)
  chore(version): 2024.11.22.0
  refactor: update API response for JSON deserialization errors (#6610)
  fix(connector): [Novalnet]  Get email from customer email if billing.email is not present  (#6619)
  feat(connector): [AIRWALLEX] Update production endpoint (#6632)
  feat(themes): Add `theme_name` and `entity_type` in themes table (#6621)
  feat(connector): [Xendit] Template PR (#6593)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] align the JSON deserialization errors into expected ErrorResponse format
5 participants