Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: global search filters access check #1816

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

sagarnaikjuspay
Copy link
Contributor

@sagarnaikjuspay sagarnaikjuspay commented Nov 27, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

checking if the user has a acess to view rhe filetrs suggestions on global search

Motivation and Context

How did you test it?

if the uer doesn't have a acess he should be shown a suggestions for filters selected

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@sagarnaikjuspay sagarnaikjuspay self-assigned this Nov 27, 2024
@sagarnaikjuspay sagarnaikjuspay requested a review from a team as a code owner November 27, 2024 11:28
Copy link

Review changes with  SemanticDiff

@sagarnaikjuspay sagarnaikjuspay linked an issue Nov 27, 2024 that may be closed by this pull request
@sagarnaikjuspay sagarnaikjuspay added analytics S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Nov 27, 2024
@JeevaRamu0104 JeevaRamu0104 added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit 5705b5d Nov 27, 2024
23 of 24 checks passed
@JeevaRamu0104 JeevaRamu0104 deleted the global-search-permission branch November 27, 2024 14:27
@github-actions github-actions bot added Closed Applied to issues or pull requests that have been successfully resolved or completed and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed analytics labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

global search filters acces check
4 participants