Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: reverting routing filtering connector list changes #1781

Merged
merged 1 commit into from
Nov 22, 2024
Merged

chore: reverting routing filtering connector list changes #1781

merged 1 commit into from
Nov 22, 2024

Conversation

gitanjli525
Copy link
Contributor

@gitanjli525 gitanjli525 commented Nov 22, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

reverting filtering of routing connector list as backend changes are required to support this change

Motivation and Context

How did you test it?

  • try updating connector list ordering in routing > default fallback , api should not fail

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@gitanjli525 gitanjli525 self-assigned this Nov 22, 2024
@gitanjli525 gitanjli525 requested a review from a team as a code owner November 22, 2024 07:38
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@gitanjli525 gitanjli525 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed core Status: issues related to core labels Nov 22, 2024
@gitanjli525 gitanjli525 linked an issue Nov 22, 2024 that may be closed by this pull request
[CHORE]: revert connector list filtering in routing #1782
Closed
@prajwalnl0 prajwalnl0 added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit c5126a0 Nov 22, 2024
19 of 27 checks passed
@prajwalnl0 prajwalnl0 deleted the revert-filtering-routing-lisrt branch November 22, 2024 12:45
@github-actions github-actions bot added Closed Applied to issues or pull requests that have been successfully resolved or completed and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed core Status: issues related to core labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanikabansal-juspay kanikabansal-juspay kanikabansal-juspay approved these changes

@sagarnaikjuspay sagarnaikjuspay sagarnaikjuspay approved these changes

Assignees

@gitanjli525 gitanjli525

Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CHORE]: revert connector list filtering in routing
4 participants
@gitanjli525 @sagarnaikjuspay @kanikabansal-juspay @prajwalnl0