Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update org name #1669

Merged
merged 9 commits into from
Nov 13, 2024
Merged

feat: update org name #1669

merged 9 commits into from
Nov 13, 2024

Conversation

gitanjli525
Copy link
Contributor

@gitanjli525 gitanjli525 commented Oct 29, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Allowing Org admins to update org name

image
image
image

Motivation and Context

How did you test it?

Click on pencil icon on Org switch dropdown box
Enter new org name
org name gets updated in dropdown

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@gitanjli525 gitanjli525 self-assigned this Oct 29, 2024
@gitanjli525 gitanjli525 requested a review from a team as a code owner October 29, 2024 11:09
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Oct 29, 2024 •
edited
Loading

Review changes with  SemanticDiff

@gitanjli525 gitanjli525 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed core Status: issues related to core labels Oct 29, 2024
@gitanjli525 gitanjli525 linked an issue Oct 29, 2024 that may be closed by this pull request
[FEAT]: allow org admins to update org name #1670
Closed
@sarojtailor
Copy link

Will clicking on the pencil icon open the modal? Also, can we have the pencil icon with the org name and not the title

@gitanjli525
Copy link
Contributor Author

Will clicking on the pencil icon open the modal? Also, can we have the pencil icon with the org name and not the title

Yes @sarojtailor it opens the modal, okay will check how it looks with pencil near org name

@JeevaRamu0104 JeevaRamu0104 added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Nov 13, 2024
@gitanjli525 gitanjli525 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Nov 13, 2024
@prajwalnl0 prajwalnl0 added this pull request to the merge queue Nov 13, 2024
Merged via the queue into main with commit 8b53637 Nov 13, 2024
6 checks passed
@prajwalnl0 prajwalnl0 deleted the update-org-name branch November 13, 2024 10:12
@github-actions github-actions bot added Closed Applied to issues or pull requests that have been successfully resolved or completed and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed core Status: issues related to core labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagarnaikjuspay sagarnaikjuspay sagarnaikjuspay approved these changes

@JeevaRamu0104 JeevaRamu0104 JeevaRamu0104 approved these changes

Assignees

@gitanjli525 gitanjli525

Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT]: allow org admins to update org name
5 participants
@gitanjli525 @sarojtailor @JeevaRamu0104 @sagarnaikjuspay @prajwalnl0