Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] : Implement Mobile Responsiveness for Home page #6127 #1645

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Vaibhav91one
Copy link

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Mobile responsive Home page

Motivation and Context

How did you test it?

I tested it locally. PFA screenshot
image

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@Vaibhav91one Vaibhav91one requested a review from a team as a code owner October 23, 2024 16:16
Copy link

semanticdiff-com bot commented Oct 23, 2024

Review changes with  SemanticDiff

@@ -215,7 +215,7 @@ module ControlCenter = {
/>
<img
alt="connector-list"
className="inline-block absolute right-5 bottom-5 lg:block"
className="opacity-10 sm:opacity-100 inline-block absolute right-5 bottom-5 lg:block"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using opacity to control responsiveness might not be ideal here. Consider using width classes to ensure the image scales properly across all screen sizes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey , Sorry for the late response, PFA other options.

  1. Option_1 : flex flex-col

image
2. . Option:_2: size-3/12 sm:size-fit

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest hacktoberfest-accepted S-conventions-not-followed Status: This PR does not follow contributing guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants