fix: filter sessionized metrics (#1761)

Co-authored-by: prajwalnl0 <[email protected]>
juspay · Nov 19, 2024 · 8ab03a6 · 8ab03a6
1 parent 1ad7cae
commit 8ab03a6
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 8 deletions.
diff --git a/src/screens/Analytics/AnalyticsUtils.res b/src/screens/Analytics/AnalyticsUtils.res
@@ -785,3 +785,12 @@ type getFilters = {
   endTime: string,
   filterValueFromUrl?: JSON.t,
 }
+
+let filterMetrics = metrics => {
+  metrics->Array.filter(ele => {
+    let metricName = ele->getDictFromJsonObject->getString("name", "")
+    !String.includes(metricName, "sessionized") &&
+    metricName != "failure_reasons" &&
+    metricName != "payments_distribution"
+  })
+}
diff --git a/src/screens/Analytics/DisputeAnalytics/DisputeAnalytics.res b/src/screens/Analytics/DisputeAnalytics/DisputeAnalytics.res
@@ -16,7 +16,12 @@ let make = () => {
     try {
       let infoUrl = getURL(~entityName=ANALYTICS_DISPUTES, ~methodType=Get, ~id=Some("dispute"))
       let infoDetails = await fetchDetails(infoUrl)
-      setMetrics(_ => infoDetails->getDictFromJsonObject->getArrayFromDict("metrics", []))
+      let metrics =
+        infoDetails
+        ->getDictFromJsonObject
+        ->getArrayFromDict("metrics", [])
+        ->AnalyticsUtils.filterMetrics
+      setMetrics(_ => metrics)
       setDimensions(_ => infoDetails->getDictFromJsonObject->getArrayFromDict("dimensions", []))
       setScreenState(_ => PageLoaderWrapper.Success)
     } catch {

diff --git a/src/screens/Analytics/PaymentsAnalytics/PaymentAnalytics.res b/src/screens/Analytics/PaymentsAnalytics/PaymentAnalytics.res
@@ -29,12 +29,7 @@ let make = () => {
         infoDetails
         ->getDictFromJsonObject
         ->getArrayFromDict("metrics", [])
-        ->Array.filter(ele => {
-          let metricName = ele->getDictFromJsonObject->getString("name", "")
-          !String.includes(metricName, "sessionized") &&
-          metricName != "failure_reasons" &&
-          metricName != "payments_distribution"
-        })
+        ->AnalyticsUtils.filterMetrics
       setMetrics(_ => ignoreSessionizedPayment)
       setDimensions(_ => infoDetails->getDictFromJsonObject->getArrayFromDict("dimensions", []))
       setScreenState(_ => PageLoaderWrapper.Success)

diff --git a/src/screens/Analytics/RefundsAnalytics/RefundsAnalytics.res b/src/screens/Analytics/RefundsAnalytics/RefundsAnalytics.res
@@ -16,7 +16,12 @@ let make = () => {
     try {
       let infoUrl = getURL(~entityName=ANALYTICS_REFUNDS, ~methodType=Get, ~id=Some(domain))
       let infoDetails = await fetchDetails(infoUrl)
-      setMetrics(_ => infoDetails->getDictFromJsonObject->getArrayFromDict("metrics", []))
+      let metrics =
+        infoDetails
+        ->getDictFromJsonObject
+        ->getArrayFromDict("metrics", [])
+        ->AnalyticsUtils.filterMetrics
+      setMetrics(_ => metrics)
       setDimensions(_ => infoDetails->getDictFromJsonObject->getArrayFromDict("dimensions", []))
       setScreenState(_ => PageLoaderWrapper.Success)
     } catch {