feat(router): use only card number for card duplication check #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NishantJoshi00
approved these changes
Dec 11, 2023
Comment on lines
+16
to
19
| pub card_number: masking::StrongSecret<String>, | ||
| name_on_card: Option<String>, | ||
| card_exp_month: Option<String>, | ||
| card_exp_year: Option<String>, |
There was a problem hiding this comment.
nit: in the future, we shouldn't have any of the fields on Card as public. We should either expose an interface for accessing the data as mutation
Chethan-rao
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we are taking the hash of entire card details (payment method data) for card duplication check. In this case if a add card request is made for same card number but with a different card holder name, cvv or expiry it would pass the card duplication check and the card would get added even though the card number is same.
So this pr treats the card number as a unique field and performs the duplication based on it.
Test case :-
3) Locker db still has only one card inserted in locker table.
4) Also there is only one entry in the hash table as well.