feat: update need newer file #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clear the logic
juraj-hrivnak
requested changes
Oct 8, 2024
src/commonMain/kotlin/teksturepako/pakku/api/actions/update/Update.kt
Outdated
Show resolved
Hide resolved
src/commonMain/kotlin/teksturepako/pakku/api/actions/update/Update.kt
Outdated
Show resolved
Hide resolved
src/commonMain/kotlin/teksturepako/pakku/api/projects/ProjectFile.kt
Outdated
Show resolved
Hide resolved
juraj-hrivnak
requested changes
Oct 8, 2024
| acc -= accProject | ||
| acc += combinedProject | ||
| } | ||
| val accFiles = projectsToFiles[accProject]!! |
There was a problem hiding this comment.
The fold is iterating the keys of the map. And the lines below ensured the key exists. It's a bug if it's null
There was a problem hiding this comment.
Yes, but it shouldn't throw NPE when there is a bug. Maybe the function should return a Result<MutableSet<Project>, ActionError>
There was a problem hiding this comment.
How to describe the error?
There was a problem hiding this comment.
UpdateFailed(val project: Project, val reason: String) : ActionError("Failed to update ${project.type} ${project.slug}; $reason")
For the message use ${project.getFullMsg()}
Also, the reason should tell what happened wrong.
src/commonMain/kotlin/teksturepako/pakku/api/actions/update/Update.kt
Outdated
Show resolved
Hide resolved
src/commonMain/kotlin/teksturepako/pakku/api/projects/ProjectFile.kt
Outdated
Show resolved
Hide resolved
juraj-hrivnak
requested changes
Oct 8, 2024
src/commonMain/kotlin/teksturepako/pakku/api/projects/ProjectFile.kt
Outdated
Show resolved
Hide resolved
juraj-hrivnak
requested changes
Oct 8, 2024
src/commonMain/kotlin/teksturepako/pakku/api/projects/ProjectFile.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When targeting multi loader mods. Some mod has older version that mark as supporting prefer loader sorted by #36 will become the first.
This PR make the update require the files on particular platform newer than the local by recording the publishing date for project files.