-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add project aliases config #34
Merged
juraj-hrivnak
merged 7 commits into
juraj-hrivnak:main
from
SettingDust:feature/project-override
Oct 8, 2024
Merged
feat: add project aliases config #34
juraj-hrivnak
merged 7 commits into
juraj-hrivnak:main
from
SettingDust:feature/project-override
Oct 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SettingDust
force-pushed
the
feature/project-override
branch
from
October 6, 2024 03:08
f315ce3
to
fd23de2
Compare
SettingDust
force-pushed
the
feature/project-override
branch
from
October 6, 2024 03:22
cdd0adf
to
b2bf4e0
Compare
juraj-hrivnak
requested changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A project should inherit the alias
&/or aliases
from the ConfigFile.ProjectConfig.
See here.
src/commonMain/kotlin/teksturepako/pakku/cli/ResolveDependencies.kt
Outdated
Show resolved
Hide resolved
juraj-hrivnak
requested changes
Oct 8, 2024
src/commonMain/kotlin/teksturepako/pakku/api/data/ConfigFile.kt
Outdated
Show resolved
Hide resolved
src/commonMain/kotlin/teksturepako/pakku/api/data/ConfigFile.kt
Outdated
Show resolved
Hide resolved
src/commonMain/kotlin/teksturepako/pakku/api/data/ConfigFile.kt
Outdated
Show resolved
Hide resolved
src/commonMain/kotlin/teksturepako/pakku/api/data/ConfigFile.kt
Outdated
Show resolved
Hide resolved
src/commonMain/kotlin/teksturepako/pakku/api/data/ConfigFile.kt
Outdated
Show resolved
Hide resolved
src/commonMain/kotlin/teksturepako/pakku/api/projects/Project.kt
Outdated
Show resolved
Hide resolved
juraj-hrivnak
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #33
fix #12