Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

Commit

Permalink
More fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
jtpio committed Oct 5, 2023
1 parent 38fd183 commit 0fa6eb4
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 4 deletions.
7 changes: 4 additions & 3 deletions jupyterlite_xeus_python/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,9 @@ def _install_pip_dependencies(prefix_path, dependencies, log=None):
Installing pip dependencies. This is very much experimental so use
this feature at your own risks.
Note that you can only install pure-python packages.
pip is being run with the --no-deps option to not pull undesired system-specific dependencies, so please
install your package dependencies from emscripten-forge or conda-forge.
pip is being run with the --no-deps option to not pull undesired
system-specific dependencies, so please install your package dependencies
from emscripten-forge or conda-forge.
"""
)

Expand Down Expand Up @@ -206,7 +207,7 @@ def _install_pip_dependencies(prefix_path, dependencies, log=None):
shutil.copy(src_path, dest_path)


def build_and_pack_emscripten_env(
def build_and_pack_emscripten_env( # noqa: C901, PLR0912, PLR0915
python_version: str = PYTHON_VERSION,
xeus_python_version: str = XEUS_PYTHON_VERSION,
packages: Optional[List[str]] = None,
Expand Down
8 changes: 7 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -124,11 +124,17 @@ ignore = [
# extended flake8 ignore
"D104", "D100", "EM101",
# Probable insecure usage of temporary file or directory
"S108"
"S108",
# RUF012 Mutable class attributes should be annotated with `typing.ClassVar`
"RUF012",
]

[tool.ruff.per-file-ignores]
# S101 Use of `assert` detected
# F841 Local variable `foo` is assigned to but never used
# PLR2004 Magic value used in comparison
"tests/*" = ["S101", "F841", "PLR2004"]

# E501 `subprocess` call: check for execution of untrusted input
# S603 `subprocess` call: check for execution of untrusted input
"jupyterlite_xeus_python/build.py" = ["E501", "S603"]

0 comments on commit 0fa6eb4

Please sign in to comment.