Skip to content
This repository has been archived by the owner on Feb 16, 2023. It is now read-only.

Remove unused build:test task in app #293

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

loichuder
Copy link
Contributor

@loichuder loichuder commented Nov 25, 2021

To make jlpm build:test work from the top-level.

Should jlpm test be run in the CI, btw ? -> https://github.com/jupyterlab/retrolab/blob/main/.github/workflows/build.yml

@welcome
Copy link

welcome bot commented Nov 25, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@github-actions
Copy link
Contributor

Binder 👈 Launch RetroLab on Binder

@jtpio jtpio added this to the 0.3.x milestone Nov 25, 2021
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@jtpio jtpio merged commit 1f4613b into jupyterlab:main Nov 25, 2021
@welcome
Copy link

welcome bot commented Nov 25, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@loichuder loichuder deleted the unused-build-test branch November 26, 2021 07:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants