Skip to content
This repository has been archived by the owner on Feb 16, 2023. It is now read-only.

Hoist the filebrowser factory plugin #249

Merged
merged 2 commits into from
Oct 12, 2021
Merged

Hoist the filebrowser factory plugin #249

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75ac401
Hoist the filebrowser factory plugin
jtpio Oct 11, 2021
6c1129c
factory is already registered in edit
jtpio Oct 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions app/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,9 @@ async function main() {
['@jupyterlab/docmanager-extension:plugin'].includes(id)
),
require('@jupyterlab/docprovider-extension'),
require('@jupyterlab/filebrowser-extension').default.filter(({ id }) =>
['@jupyterlab/filebrowser-extension:factory'].includes(id)
),
require('@jupyterlab/fileeditor-extension').default.filter(({ id }) =>
['@jupyterlab/fileeditor-extension:plugin'].includes(id)
),
Expand Down Expand Up @@ -156,7 +159,6 @@ async function main() {
[
'@jupyterlab/filebrowser-extension:browser',
'@jupyterlab/filebrowser-extension:download',
'@jupyterlab/filebrowser-extension:factory',
'@jupyterlab/filebrowser-extension:file-upload-status',
'@jupyterlab/filebrowser-extension:open-with',
'@jupyterlab/filebrowser-extension:share-file'
Expand Down Expand Up @@ -201,10 +203,7 @@ async function main() {
['@jupyterlab/completer-extension:files'].includes(id)
),
require('@jupyterlab/filebrowser-extension').default.filter(({ id }) =>
[
'@jupyterlab/filebrowser-extension:browser',
'@jupyterlab/filebrowser-extension:factory'
].includes(id)
['@jupyterlab/filebrowser-extension:browser'].includes(id)
)
]);
break;
Expand Down