Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Pytest 8.1 #135

Merged
merged 8 commits into from
Apr 3, 2024
Merged

Conversation

krassowski
Copy link
Member

#133 alternative to #134 I guess

Copy link

welcome bot commented Mar 4, 2024

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@krassowski krassowski marked this pull request as draft March 4, 2024 11:58
@krassowski
Copy link
Member Author

Yup, looking at CI it will take a bit more work, switching to draft for now - feel free to pick up @blink1073

@blink1073
Copy link
Contributor

I ran into several problems: flaky appears to be abandoned and incompatible, pytest-retry also appears to be incompatible by I wanted to get a hotfix out ASAP.

@krassowski
Copy link
Member Author

Yes, I totally agree 💯

pyproject.toml Outdated
@@ -28,7 +28,7 @@ dependencies = [
"html5lib",
"nbconvert",
"nbformat",
"pytest >=7.0,<9",
"pytest >=8.1,<9",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: The changes in this PR are compatible with Pytest 7.0+ ; you don't have to bump the minimum version.

@blink1073
Copy link
Contributor

It looks like we're now compatible with Pytest 8, #136. Thanks for looking into this!

@blink1073 blink1073 closed this Apr 3, 2024
@mr-c
Copy link

mr-c commented Apr 3, 2024

@blink1073 I don't think so; is your CI actually running the newer pytest version? You still need the changes in this PR for pytest 8.1 compat

@blink1073
Copy link
Contributor

Hmm, you're right @mr-c, it didn't actually install pytest 8 even though the constraint was lifted...

@blink1073 blink1073 reopened this Apr 3, 2024
@blink1073
Copy link
Contributor

Oh, wait, no, it did, I was looking at a prior run: https://github.com/jupyterlab/pytest-check-links/actions/runs/8537702936/job/23388842190

@blink1073 blink1073 closed this Apr 3, 2024
@mr-c
Copy link

mr-c commented Apr 3, 2024

Ah, pytest 8.1.0 breaks without these changes , but then 8.1.0 was pulled. 8.1.1 issues warnings. Will you still merge this PR so that pytest 8.2 or 9.0 won't break? Setting a minimum version of 7.0 for Pytest is also still a good idea

@blink1073 blink1073 reopened this Apr 3, 2024
pyproject.toml Outdated Show resolved Hide resolved
@blink1073 blink1073 marked this pull request as ready for review April 3, 2024 15:19
@blink1073 blink1073 enabled auto-merge (squash) April 3, 2024 16:31
@blink1073 blink1073 merged commit 5eda408 into jupyterlab:main Apr 3, 2024
21 checks passed
Copy link

welcome bot commented Apr 3, 2024

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@blink1073 blink1073 changed the title Support and require pytest 8.1 Support Pytest 8.1 Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants