Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to JupyterLab 3 #29

Merged
merged 16 commits into from
Apr 6, 2021
Merged

Port to JupyterLab 3 #29

merged 16 commits into from
Apr 6, 2021

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented Mar 8, 2021

To fix:

  • it does not work in federated mode
  • Some styles are broken in notebook diff

@bollwyvl
Copy link
Contributor

bollwyvl commented Mar 8, 2021

Happy to help if we can find tasks to divide and conquer, but a little insight into the path forward on #27 would help!

@fcollonval fcollonval marked this pull request as ready for review March 13, 2021 11:20
@fcollonval fcollonval marked this pull request as draft March 13, 2021 11:39
@bollwyvl
Copy link
Contributor

@fcollonval fcollonval marked this pull request as ready for review April 6, 2021 07:52
@fcollonval
Copy link
Member Author

Let's merge this overdue port - I will publish a version for JLab 3 within the week.

@fcollonval fcollonval merged commit 776fef8 into jupyterlab:master Apr 6, 2021
@fcollonval fcollonval deleted the ft/jlab3 branch April 6, 2021 08:02
@bollwyvl
Copy link
Contributor

bollwyvl commented Apr 6, 2021

I'm kinda out of pocket at the moment, but will definitely see about getting that binder PR up against this when next i have the chance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants