Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For v2 extensions parse entrypoint data #445

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

AshokChoudhary11
Copy link
Contributor

@AshokChoudhary11 AshokChoudhary11 commented Mar 20, 2024

This change will make entrypoint data available for jupyterlab application.
It will be consumed for loading the plugins in a no-code way. Refer https://hackmd.io/DBlDBDszSVSjYK9ieg1mZA

Copy link

welcome bot commented Mar 20, 2024

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AshokChoudhary11

I proposed a simplification.

Could you write down some prose in the PR description to explain why you are proposing this changes and what it adds?

jupyterlab_server/config.py Outdated Show resolved Hide resolved
Co-authored-by: Frédéric Collonval <[email protected]>
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fcollonval fcollonval merged commit 8d036f5 into jupyterlab:main Apr 8, 2024
27 of 29 checks passed
Copy link

welcome bot commented Apr 8, 2024

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants