Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some CodeQL notices #371

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Conversation

fcollonval
Copy link
Member

No description provided.

@fcollonval fcollonval enabled auto-merge (squash) February 7, 2023 07:49
@codecov-commenter
Copy link

Codecov Report

Base: 81.18% // Head: 80.56% // Decreases project coverage by -0.63% ⚠️

Coverage data is based on head (7909637) compared to base (bcbbc35).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #371      +/-   ##
==========================================
- Coverage   81.18%   80.56%   -0.63%     
==========================================
  Files          22       21       -1     
  Lines        1765     1760       -5     
  Branches      333      333              
==========================================
- Hits         1433     1418      -15     
- Misses        229      235       +6     
- Partials      103      107       +4     
Impacted Files Coverage Δ
jupyterlab_server/config.py 73.52% <100.00%> (ø)
jupyterlab_server/handlers.py 78.23% <100.00%> (ø)
jupyterlab_server/licenses_handler.py 97.63% <100.00%> (ø)
jupyterlab_server/listings_handler.py 82.92% <100.00%> (ø)
jupyterlab_server/settings_utils.py 77.88% <100.00%> (-0.83%) ⬇️
jupyterlab_server/themes_handler.py 81.81% <100.00%> (-0.41%) ⬇️
jupyterlab_server/workspaces_handler.py 88.28% <100.00%> (+0.09%) ⬆️
jupyterlab_server/process.py 61.72% <0.00%> (-3.71%) ⬇️
jupyterlab_server/translation_utils.py 89.07% <0.00%> (-0.85%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fcollonval fcollonval merged commit aff43d3 into jupyterlab:main Feb 7, 2023
@fcollonval fcollonval deleted the maintenance/codeql branch February 7, 2023 09:36
fcollonval added a commit that referenced this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants