Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase coverage #334

Merged
merged 10 commits into from
Nov 8, 2022
Merged

Increase coverage #334

merged 10 commits into from
Nov 8, 2022

Conversation

blink1073
Copy link
Contributor

Goal is to hit 80%

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2022

Codecov Report

Base: 65.11% // Head: 80.45% // Increases project coverage by +15.34% 🎉

Coverage data is based on head (9575afc) compared to base (0bd0b71).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #334       +/-   ##
===========================================
+ Coverage   65.11%   80.45%   +15.34%     
===========================================
  Files          22       22               
  Lines        1740     1699       -41     
  Branches      331      324        -7     
===========================================
+ Hits         1133     1367      +234     
+ Misses        522      229      -293     
- Partials       85      103       +18     
Impacted Files Coverage Δ
jupyterlab_server/test_utils.py 67.46% <ø> (+4.31%) ⬆️
jupyterlab_server/translation_utils.py 80.70% <ø> (+11.59%) ⬆️
jupyterlab_server/workspaces_app.py 88.05% <ø> (+50.85%) ⬆️
jupyterlab_server/workspaces_handler.py 88.80% <ø> (+7.88%) ⬆️
jupyterlab_server/process.py 63.69% <100.00%> (+63.69%) ⬆️
jupyterlab_server/handlers.py 79.26% <0.00%> (+1.21%) ⬆️
jupyterlab_server/config.py 73.96% <0.00%> (+10.05%) ⬆️
jupyterlab_server/listings_handler.py 82.92% <0.00%> (+34.14%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073 blink1073 marked this pull request as ready for review November 8, 2022 03:04
tests/test_config.py Fixed Show fixed Hide fixed
@bollwyvl
Copy link
Contributor

bollwyvl commented Nov 8, 2022

Base: 65.11% // Head: 80.45% // Increases project coverage by +15.34% tada

well done, old chum!

I applaud the goal, and do wonder if we can get some more on-going bang for the coverage buck with e.g. schemathesis... nothing wrong with cranking up the specificity of the API description as well. These might want to be gated behind a flag, as they can be... long. Especially once you use them for a while.

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @blink1073

@blink1073 blink1073 merged commit 45117ee into jupyterlab:main Nov 8, 2022
@blink1073 blink1073 deleted the improve-coverage branch November 8, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants