Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflows and add new ones #318

Merged
merged 2 commits into from
Oct 14, 2022

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented Oct 14, 2022

This fixes most CodeQL advices

@codecov-commenter
Copy link

Codecov Report

Base: 65.20% // Head: 65.17% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (0103dd7) compared to base (f63822f).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #318      +/-   ##
==========================================
- Coverage   65.20%   65.17%   -0.04%     
==========================================
  Files          22       22              
  Lines        1739     1743       +4     
  Branches      274      290      +16     
==========================================
+ Hits         1134     1136       +2     
- Misses        521      523       +2     
  Partials       84       84              
Impacted Files Coverage Δ
jupyterlab_server/__init__.py 90.90% <ø> (ø)
jupyterlab_server/licenses_handler.py 98.41% <0.00%> (-0.79%) ⬇️
jupyterlab_server/process.py 0.00% <0.00%> (ø)
jupyterlab_server/settings_utils.py 78.50% <ø> (-0.10%) ⬇️
jupyterlab_server/test_utils.py 63.15% <0.00%> (-0.68%) ⬇️
jupyterlab_server/translation_utils.py 69.11% <ø> (+0.77%) ⬆️
jupyterlab_server/listings_handler.py 48.78% <0.00%> (+1.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fcollonval fcollonval marked this pull request as ready for review October 14, 2022 14:52
@fcollonval fcollonval merged commit bc387f1 into jupyterlab:main Oct 14, 2022
@fcollonval fcollonval deleted the maintenance/fix-ci branch October 14, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants