Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also look in static for license files #238

Merged
merged 2 commits into from
Jan 27, 2022

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Jan 26, 2022

It looks like a fair number of packages have started including third-party-licenses.json, but they have not been showing up in the UI/CLI.

The simple reason here being that @jupyterlab/builder puts them in static (as opposed to next to package.json).

This PR checks in both locations, and adds a test for the more common static case.

@blink1073
Copy link
Contributor

Kicked the check release jobs

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2022

Codecov Report

Merging #238 (a418d63) into main (d577120) will decrease coverage by 0.63%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
- Coverage   76.96%   76.33%   -0.64%     
==========================================
  Files          28       29       +1     
  Lines        2071     2227     +156     
==========================================
+ Hits         1594     1700     +106     
- Misses        477      527      +50     
Impacted Files Coverage Δ
jupyterlab_server/licenses_handler.py 100.00% <100.00%> (ø)
jupyterlab_server/tests/test_licenses_api.py 100.00% <100.00%> (ø)
jupyterlab_server/handlers.py 87.80% <0.00%> (-0.02%) ⬇️
jupyterlab_server/tests/test_settings_api.py 100.00% <0.00%> (ø)
jupyterlab_server/workspaces_app.py 36.47% <0.00%> (ø)
jupyterlab_server/workspaces_handler.py 87.02% <0.00%> (+2.27%) ⬆️
jupyterlab_server/settings_utils.py 86.04% <0.00%> (+2.47%) ⬆️
jupyterlab_server/__init__.py 90.00% <0.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d577120...a418d63. Read the comment docs.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit 655d8e9 into jupyterlab:main Jan 27, 2022
@bollwyvl
Copy link
Contributor Author

thanks for the speedy review, and sorry for not checking it out sooner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants