Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically close “answered” issues if they have no activity for 30 days #9920

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Mar 9, 2021

References

Code changes

User-facing changes

Often we have questions opened as issues that we have answered, but then there is no follow-up from the submitter and the issue stays open. This enables us to explicitly indicate we have answered the question by giving the issue the status:Answered label, and then after 30 days of inactivity, the issue is scheduled to be closed after one more week, presumably answered.

We could add a message before closure, but when we did that for the resolved-locked issues, it seemed to be mostly annoying without doing any good, so I opted for a silent scheduling, then closure a week later. The issue won't be locked for another 6 months of inactivity, so the submitter can always comment again and we can reopen it.

If this is merged, we'll need to create the labels status:Answered and status:Closing as Answered.

Backwards-incompatible changes

… days.

Often we have questions opened as issues that we have answered, but then there is no follow-up from the submitter. This enables us to indicate we have answered the question, and then the issue is scheduled to be closed after 30 days, presumably answered.
@jasongrout jasongrout added this to the 3.1 milestone Mar 9, 2021
@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jtpio
Copy link
Member

jtpio commented Mar 9, 2021

Thanks!

This should help (or close?) with this issue: #9714

@jasongrout
Copy link
Contributor Author

This should help (or close?) with this issue: #9714

Help, but probably not close. This doesn't take the hard line of closing any stale issue, just ones where we have explicitly indicated that we've triaged the issue as a user question (e.g., an installation issue, etc.) and tried to answer it.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@blink1073 blink1073 merged commit 8c08ea0 into jupyterlab:master Mar 9, 2021
@jasongrout
Copy link
Contributor Author

If this is merged, we'll need to create the labels status:Answered and status:Closing as Answered.

I did this.

@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jan 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants