Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate open tabs into running panel #8886

Merged
merged 17 commits into from
Sep 14, 2020
Merged

Integrate open tabs into running panel #8886

merged 17 commits into from
Sep 14, 2020

Conversation

ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Aug 23, 2020 •
edited
Loading

Todo:

  • Make sure the tabsmanager extension is properly and fully removed.
  • Hide shutdown buttons and/or section when there are no running items (post-3.0).
  • Wire up document icons in open tabs (this can be done after 3.0 if needed).
  • Change "SHUT DOWN" text to close icon on a per item basis.
  • Change close icon for each section to appropriate text title (Close All, Shutdown All, etc.)
  • Remove old open tabs extension.
  • Separate index.ts for running extension into separate files.
  • Wire up translator for open tabs section.

References

#8650

Code changes

  • Adds new section and associated manager and running items to the running extension to represent open tabs.
  • Adds optional detail to IRunningItem to provide a second column of information after the label.
  • Adds optional shutdownLabel, shutdownAll, shutdownAllConfirmationText, shutdownItemIcon to IRunningSessions.IManager to allow sections to customize language and iconography of "shutting down".

User-facing changes

  • No more separate left panel for open tabs.
  • Open tabs section is present in the running panel.

Screen Shot 2020-09-04 at 12 19 00 PM

Backwards-incompatible changes

None.

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@github-actions github-actions bot added pkg:running tag:Design System CSS If a PR is editing any CSS files please add this tag for design team to review. pkg:extensionmanager pkg:tabmanager tag:CSS For general CSS related issues and pecadilloes tag:Examples labels Aug 23, 2020
@ellisonbg
Copy link
Contributor Author

Updated screenshot:

Screen Shot 2020-08-23 at 5 10 23 PM

@blink1073 blink1073 added this to the 3.0 milestone Aug 26, 2020
@tgeorgeux tgeorgeux mentioned this pull request Aug 26, 2020
Closed
@tgeorgeux tgeorgeux mentioned this pull request Sep 2, 2020
Closed
@ellisonbg
Copy link
Contributor Author

@blink1073 I will need help on this PR briefly to make sure I am properly removing all the artifacts for the old tabmanager extension.

@ellisonbg
Copy link
Contributor Author

OK, all major things have been addressed other than needing to make sure the old tabmanager extension has been fully and properly removed. Screenshot in initial comments has been updated to reflect the current state.

@ellisonbg
Copy link
Contributor Author

Looks like the tests are failing due to some unrelated documentation links.

blink1073
blink1073 approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I caught one extra integrity change.

@ellisonbg ellisonbg marked this pull request as ready for review September 12, 2020 20:14
@ellisonbg
Copy link
Contributor Author

This is ready to be merged.

@ellisonbg
Copy link
Contributor Author

Nevermind, merge conflict, rebasing.

@ellisonbg
Copy link
Contributor Author

Rebased, should be ready for merging.

@ellisonbg
Copy link
Contributor Author

Also, this is a pain to rebase each time we release (lots of conflicting package.json files), so if we can merge before the next release, that would be nice :-)

blink1073
blink1073 approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit c9589d6 into jupyterlab:master Sep 14, 2020
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Mar 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2021
@krassowski krassowski mentioned this pull request May 11, 2021
Merged
@jupyterlab jupyterlab unlocked this conversation Mar 20, 2023
krassowski added a commit to krassowski/jupyterlab that referenced this pull request Mar 20, 2023
@krassowski
Remove dangling tab-manager references
98f725a 
these should have been removed in jupyterlab#8886
fcollonval pushed a commit that referenced this pull request Mar 31, 2023
@krassowski
Enforce a minimal set of CSS selector complexity rules (#14238)
a4aa5eb 
* Disallow more than one bare HTML tag

* Remove dangling tab-manager references

these should have been removed in #8886

* Remove dialog button rule with complex selector which has no effect

* Remove stray style which should have been removed with #6653

* Remove one more dangling tab-manager style

* Enable `selector-max-class` stylelint rule

* Enable `selector-max-compound-selectors` stylelint rule

* Enable selector-max-universal: 1 to prevent very bad CSS

(while still allowing somewhat bad CSS for now).

* Make use of `stylelint-disable-next-line` where practical
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees

@ellisonbg ellisonbg

Labels
Design System CSS pkg:extensionmanager pkg:running pkg:tabmanager pkg:terminal pkg:ui-components status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:CSS For general CSS related issues and pecadilloes tag:Design System CSS If a PR is editing any CSS files please add this tag for design team to review. tag:Examples
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ellisonbg @blink1073