Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow replacing with empty strings #8100

Merged
merged 4 commits into from
Mar 30, 2020
Merged

Allow replacing with empty strings #8100

merged 4 commits into from
Mar 30, 2020

Conversation

jasongrout
Copy link
Contributor

References

Fixes #8098

Code changes

Fix boolean logic to allow replacing with empty strings.

User-facing changes

Fix replace button active and hover states:

Screen Shot 2020-03-27 at 6 32 12 AM

Backwards-incompatible changes

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout jasongrout mentioned this pull request Mar 27, 2020
Closed
@jasongrout jasongrout added this to the 2.1 milestone Mar 27, 2020
@github-actions github-actions bot added tag:Design System CSS If a PR is editing any CSS files please add this tag for design team to review. pkg:documentsearch tag:CSS For general CSS related issues and pecadilloes labels Mar 27, 2020
saulshanabrook
saulshanabrook suggested changes Mar 27, 2020
View reviewed changes
Copy link
Member

@saulshanabrook saulshanabrook left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for a single "replace" but doesn't seem to work for "replace all" which seems like a bug

@jasongrout
Copy link
Contributor Author

This works for a single "replace" but doesn't seem to work for "replace all" which seems like a bug

Yep, good catch. Same change was needed in the next function used for replaceAll.

saulshanabrook
saulshanabrook approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@saulshanabrook saulshanabrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now for me!

@saulshanabrook saulshanabrook merged commit 83cd6c9 into jupyterlab:master Mar 30, 2020
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label May 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@saulshanabrook saulshanabrook saulshanabrook approved these changes

Assignees
No one assigned
Labels
pkg:documentsearch status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:CSS For general CSS related issues and pecadilloes tag:Design System CSS If a PR is editing any CSS files please add this tag for design team to review.
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

Cannot replace with an empty text
2 participants
@jasongrout @saulshanabrook