Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #7264: use default app_dir when app_dir == '' #7268

Merged
merged 1 commit into from
Sep 27, 2019
Merged

fixes #7264: use default app_dir when app_dir == '' #7268

merged 1 commit into from
Sep 27, 2019

Conversation

telamonian
Copy link
Member

References

fixes #7264

Code changes

Ensures that the default value of app_dir is used when app_dir == ''

User-facing changes

Extensions will install correctly, instead of lab assets building in an extension dir

Backwards-incompatible changes

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@telamonian telamonian mentioned this pull request Sep 26, 2019
Closed
@telamonian
Copy link
Member Author

@vidartf You're the one who set up all of the AppOptions stuff, right? Does this fix look reasonable to you?

vidartf
vidartf approved these changes Sep 26, 2019
View reviewed changes
Copy link
Member

@vidartf vidartf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the right fix to me. For reference, the '' value seems to mostly come from the BaseExtensionApp default.

@telamonian
Copy link
Member Author

The remaining test failure is just that NASA link in the docs, so I'll merge this

@telamonian telamonian merged commit 457223a into jupyterlab:master Sep 27, 2019
@telamonian telamonian added this to the 2.0 milestone Sep 27, 2019
@telamonian
Copy link
Member Author

@blink1073 @vidartf Does this need to get backported?

@blink1073
Copy link
Contributor

@jasongrout, did you include #7079 in the 1.x branch? If not, not further action is required. If so, this needs to be backported to 1.x.

@blink1073 blink1073 mentioned this pull request Oct 15, 2019
Closed
@telamonian
Copy link
Member Author

@meeseeksdev backport to 1.x

@meeseeksmachine meeseeksmachine mentioned this pull request Oct 15, 2019
Merged
meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Oct 15, 2019
@telamonian
Backport PR jupyterlab#7268: fixes jupyterlab#7264: use default `app_…
c52bf90 
…dir` when `app_dir == ''`
telamonian added a commit that referenced this pull request Oct 15, 2019
@telamonian
Merge pull request #7361 from meeseeksmachine/auto-backport-of-pr-726…
e68729b 
…8-on-1.x

Backport PR #7268 on branch 1.x (fixes #7264: use default `app_dir` when `app_dir == ''`)
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Nov 14, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vidartf vidartf vidartf approved these changes

Assignees
No one assigned
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

Build System Broken in Master
3 participants
@telamonian @blink1073 @vidartf