Update to the latest Lumino

[jtpio]

References

Extract the Lumino update from #16794 to another PR, to avoid noise in #16794 and fix potential issues with this update not necessarily related to #16794.

Closes #16674

Code changes

• Update @lumino packages
• Fix accessing the app _plugins in the UI tests
• Fix overflow: hidden CSS rule for menus

User-facing changes

None?

Backwards-incompatible changes

None

[jupyterlab-probot]

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link:

[krassowski]

What do you think about releasing another beta before merging this one? I know it can be annoying as it can cause merge conflicts, but my reasoning is that this will allow to narrow down any regressions by installing different versions?

[jtpio]

Yeah it would be great to have this Lumino update out soon so it can be tested with extensions and downstream in Notebook 7.

But then that would mean releasing now, merging this PR, and making another right after (to not wait too long), which can also be tedious.

[krassowski]

When I reviewed jupyterlab/lumino#715 I noted that there is a regression with sidebar resizing behaviour, was this addressed? I do not see the changes mentioned in jupyterlab/lumino#715 (comment) in the diff but maybe it was addressed differently?

But then that would mean releasing now, merging this PR, and making another right after (to not wait too long), which can also be tedious.

Ok, I will do that - I will take care of resolving conflicts here and making two releases.

[jtpio]

When I reviewed jupyterlab/lumino#715 I noted that there is a regression with sidebar resizing behaviour, was this addressed? I do not see the changes mentioned in jupyterlab/lumino#715 (comment) in the diff but maybe it was addressed differently?

Ah maybe this is not covered by this PR then, would need to double check.

The menu overflow issues were caught by the UI tests and should now be fixed though.

[jtpio]

Just checked from this PR and there does seem be an issue when resizing the sidebar:

jupyterlab-lumino-sidebar-resize-issue.webm

[krassowski]

@jtpio rebased to resolve conflicts after release - do you want to take it from here to fix the sidebar styling?

[jtpio]

Thanks @krassowski for helping with the rebase and the conflicts!

I just pushed a commit to include the suggestions from jupyterlab/lumino#715 (comment), which seems to be fixing the sidebar issues. Let's see if CI still passes.

[krassowski]

Should we also add an entry about this in the extension migration guide, ideally with instructions how to restore old behaviour in extensions by adding overflow: hidden?

[jtpio]

Thanks for the suggestion 👍

Added in 39fd022.

[krassowski]

LGTM, just tiny suggestion on docs - I think we can continue testing this as beta3 :)

[jtpio]

Thanks @krassowski for the review 👍

Addressed the last point in 80304be.

Waiting for CI to complete to get this one in.

[jtpio]

The failing check_links does not seem related, and should hopefully fix itself soon: