Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport on 3.3.x: Toggle side-by-side rendering for current notebook (#11793) #11794

Merged
merged 2 commits into from
Jan 11, 2022
Merged

Backport on 3.3.x: Toggle side-by-side rendering for current notebook (#11793) #11794

merged 2 commits into from
Jan 11, 2022

Conversation

fcollonval
Copy link
Member

This reverts commit df6c0ee.

This backports #11793 on branch 3.3.x instead of 3.2.x as it changes a setting name.

@fcollonval fcollonval added enhancement api-change A change that should be accompanied by a major version increase labels Jan 6, 2022
@fcollonval fcollonval added this to the 3.3.x milestone Jan 6, 2022
@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@fcollonval
Copy link
Member Author

Kicking CI

@fcollonval fcollonval closed this Jan 6, 2022
@fcollonval fcollonval reopened this Jan 6, 2022
@jtpio jtpio force-pushed the revert-11793-revert-11718-backport/3.2.x/11608 branch from cd2f35c to a3a3452 Compare January 11, 2022 15:05
@jtpio
Copy link
Member

jtpio commented Jan 11, 2022

Rebased onto the latest 3.3.x.

jtpio
jtpio approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit cf902aa into 3.3.x Jan 11, 2022
@jtpio jtpio deleted the revert-11793-revert-11718-backport/3.2.x/11608 branch January 11, 2022 16:08
@fcollonval fcollonval mentioned this pull request Jan 14, 2022
Closed
20 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees

@fcollonval fcollonval

Labels
api-change A change that should be accompanied by a major version increase enhancement pkg:notebook tag:Testing
Projects
None yet
Milestone
3.3.x
Development

Successfully merging this pull request may close these issues.
2 participants
@fcollonval @jtpio