Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass version spec as an input #11322

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Oct 20, 2021

References

To fix the check release workflow on CI.

An take the recent change in the releaser into account: jupyter-server/jupyter_releaser#190

Code changes

CI

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@jtpio
Copy link
Member Author

jtpio commented Oct 20, 2021

This can be backported.

@blink1073
Copy link
Contributor

This can be backported.

Yeah, we'll need it on 3.1.x and 3.2.x

@blink1073 blink1073 added this to the 3.2.x milestone Oct 20, 2021
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073
Copy link
Contributor

I confirmed the version bump works in the logs, going ahead and merging this

@blink1073 blink1073 merged commit 8c67f59 into jupyterlab:master Oct 20, 2021
@blink1073
Copy link
Contributor

@meeseeksdev please backport to 3.1.x

@blink1073
Copy link
Contributor

@meeseeksdev please backport to 3.2.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Oct 20, 2021
blink1073 pushed a commit that referenced this pull request Oct 20, 2021
blink1073 pushed a commit that referenced this pull request Oct 20, 2021
@github-actions
Copy link
Contributor

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

The mean relative comparison is computed with 95% confidence.

Results table
Test file large_code_notebook large_md_notebook
open
chromium
actual 4455 <- [4758 - 5585 - 5805] -> 7053 2494 <- [2583 - 2614 - 2687] -> 3061
expected 4614 <- [5246 - 6163 - 6322] -> 7324 2498 <- [2591 - 2641 - 2908] -> 3552
Mean relative change -9.4% ± 2.7% -5.0% ± 2.0%
switch-from
chromium
actual 765 <- [796 - 829 - 935] -> 1795 461 <- [539 - 563 - 586] -> 770
expected 781 <- [852 - 883 - 979] -> 1944 456 <- [532 - 565 - 604] -> 699
Mean relative change -5.6% ± 4.5% -0.8% ± 2.4%
switch-to
chromium
actual 650 <- [697 - 708 - 737] -> 822 523 <- [594 - 603 - 614] -> 701
expected 682 <- [751 - 768 - 779] -> 872 533 <- [601 - 612 - 663] -> 1826
Mean relative change -6.4% ± 1.2% -5.5% ± 3.9%
close
chromium
actual 728 <- [790 - 816 - 868] -> 1211 498 <- [522 - 541 - 609] -> 714
expected 767 <- [837 - 860 - 910] -> 1194 487 <- [523 - 568 - 598] -> 706
Mean relative change -5.8% ± 3.1% -1.2% ± 2.5%

Changes are computed with expected as reference.

@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Apr 19, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants