Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive document toolbars #10595

Closed
ellisonbg opened this issue Jul 9, 2021 · 6 comments
Closed

Responsive document toolbars #10595

ellisonbg opened this issue Jul 9, 2021 · 6 comments
Assignees
Labels
enhancement pkg:notebook status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Design and UX
Milestone

Comments

@ellisonbg
Copy link
Contributor

Problem

Documents such as notebooks in JupyterLab can have a toolbar of widgets (buttons, dropdowns, etc.). Extensions can add widgets to the toolbars and for a given panel width, the total number of widgets may not fit in the available space. Currently, buttons that overflow off the right side of the toolbar are not visible and there is no way for users to see or use those widgets.

Proposed Solution

We should explore ways to make the extensible toolbar widgets responsive. The solution I would propose is to put widgets that don't fit behind a triple-doc or "more" button that contains the additional widgets. This is a common pattern is responsive toolbar design.

One aspect we will need to consider is which widgets will be hidden. My sense is that builtin widgets of JupyterLab should be hidden last. We may need additional widget metadata or sectioning in the toolbar that can be used to determine which widgets are hidden in the "more" button.

Additional context

#10469 does help some by allowing users to change the content of the toolbars using settings. But as the user adjusts the width of panels, this can still be an issue.

@jasongrout
Copy link
Contributor

triple-doc

triple-dot?

Another thing I've seen is a double chevron, like »

@fcollonval
Copy link
Member

We may need additional widget metadata

FYI VS Code has a notion of primary/secondary items to distinguish those that will be gathered in a sub menu or not.

@3coins
Copy link
Contributor

3coins commented Jul 12, 2021

I will start looking into this, will add some screenshots of possible solutions.

@fcollonval
Copy link
Member

Hey @3coins if you can provide you support for technical question. The best would be to open quickly a PR so we can discuss there. Or you can contact me via gitter. Let me know also if you want to discuss design for this feature.

@3coins
Copy link
Contributor

3coins commented Jul 15, 2021

Hey @3coins if you can provide you support for technical question. The best would be to open quickly a PR so we can discuss there. Or you can contact me via gitter. Let me know also if you want to discuss design for this feature.

Sure, I don't have any code changes yet to create a pull request. Will contact you on gitter to discuss.

@jtpio
Copy link
Member

jtpio commented Nov 1, 2021

Closing as fixed by #10720, thanks!

With a follow-up issue: #10749

@jtpio jtpio closed this as completed Nov 1, 2021
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label May 1, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement pkg:notebook status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Design and UX
Projects
None yet
Development

No branches or pull requests

6 participants