changes to import monaco-lsp code into jupyterlab-monaco #12

juliandolby · 2018-06-27T17:17:35Z

here is a minimal set of changes i needed to get jupyterlab-monaco to build and run while importing monaco-languageclient

dhirschfeld · 2018-07-24T00:07:08Z

Excited to see this progress, especially in light of the upcoming release of the Python Language Server:

https://blogs.msdn.microsoft.com/pythonengineering/2018/07/18/introducing-the-python-language-server/

juliandolby · 2018-07-24T00:21:57Z

I just merged the latest from jupyterlab-monaco, and pushed the merged code to my branch. I think that ought to update the pull request

ellisonbg · 2018-07-26T15:57:09Z

@juliandolby JupyterLab 0.33 is coming out this week. Can you update the PR to use that release of JupyterLab and then maybe we can merge this PR. @jasongrout do you think you will have a chance to help review this after the release?

ellisonbg · 2018-07-26T16:13:53Z

A few thoughts about LSP integration:

We probably want to have a jupyter notebook server extension that can act as a proxy between specific LSPs and the frontend, through a standard web socket protocol and URLs. I am thinking of new endpoints like /lsp/python or /lsp/R and something that can return the list of available and running LSP servers.
A new set of classes on jupyterlab services that has a well designed client to those endpoints and which returns the actual client LSP objects that Monaco needs.

Do we want to try to tackle some of these at the JupyterCon sprint on Saturday? I have meetings in NYC the following M/T, but might be available to stay around on W.

juliandolby · 2018-07-26T18:35:45Z

@ellisonbg My project is a fork of jupyterlab/monaco, and I am not sure how this connects to the overall jupyterlab. My version is slightly back, I think, for when I type

jupyter lab --version

at the command line, I get 0.32.1. I suspect this means I need to build jupyterlab itself from github to get the latest?

I definitely like the ideas for the Saturday sprint. This would allow us to interact with jupyter by simply configuring our analysis as an available server.

juliandolby · 2018-08-03T18:34:48Z

my latest commits have me reading the LSP server to use from system config. It is totally hackish right now, since I am adding my config item to an existing config entry. I have added a schema for the Monaco extension, but that does not seem to show up.

juliandolby · 2018-08-13T19:35:22Z

just merged to jupyterlab 0.33.10, and everything still seems to work. i have pushed those merges to the pull request.

ellisonbg · 2018-08-18T18:05:42Z

@juliandolby JupyterLab 0.34 is out now - do you think you will have time to update/test with 0.34 this before JupyterCon?

juliandolby · 2018-08-18T18:13:19Z

@ellisonbg I just checked, and conda, which is how I install jupyterlab, only has jupyterlab 0.33.12 using conda-forge. The extension seems to work unchanged with 0.33.12

ellisonbg · 2018-08-18T19:13:33Z

It may only be available with pip - sometimes Vonda takes a bit longer to show up

…

Sent from my iPhone

On Aug 18, 2018, at 11:13 AM, Julian Dolby ***@***.***> wrote: @ellisonbg I just checked, and conda, which is how I install jupyterlab, only has jupyterlab 0.33.12 using conda-forge. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

blink1073 · 2018-08-18T23:23:18Z

There is a problem with the linter on conda-forge, waiting for that to be resolved. Sent From Phone

________________________________ From: Brian E. Granger <[email protected]> Sent: Saturday, August 18, 2018 2:13:33 PM To: jupyterlab/jupyterlab-monaco Cc: Subscribed Subject: Re: [jupyterlab/jupyterlab-monaco] changes to import monaco-lsp code into jupyterlab-monaco (#12) It may only be available with pip - sometimes Vonda takes a bit longer to show up

Sent from my iPhone

On Aug 18, 2018, at 11:13 AM, Julian Dolby ***@***.***> wrote: @ellisonbg I just checked, and conda, which is how I install jupyterlab, only has jupyterlab 0.33.12 using conda-forge. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#12 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AB_99C_tUWIvfB2jwX5ALU-96D5pjXCcks5uSGddgaJpZM4U6FTU>.

blink1073 · 2018-08-19T11:03:03Z

@juliandolby, jupyterlab 0.34 is now available on conda-forge, and if you rebase you'll pick up #18.

juliandolby · 2018-08-19T17:40:14Z

Just updated to 0.34. I pushed the very few needed changes, just adjustments of dependency versions.

blink1073 · 2018-08-19T17:56:56Z

👍

LeanderK · 2018-08-26T19:38:55Z

How would the LSP-Server be used? How can I install (or start?) LSPs and connect to them?

juliandolby · 2018-08-27T02:29:16Z

There is now a 'Monaco Editor' tab in the advanced settings menu, which currently has the sole option 'lspServer'. You can set this to any WebSocket URL that talks to an LSP server. For example, my analysis server uses URLs of the following form: "ws://localhost:8080/com.ibm.wala.cast.lsp.tomcat/websocket". Hence, my Monaco config is as follows:

{
    // Monaco Editor
    // jupyterlab-monaco:plugin
    // Monaco editor settings.
    // ************************

    // [missing schema title]
    // The configuration specific to Monaco editors.
    "lspServer": "ws://localhost:8080/com.ibm.wala.cast.lsp.tomcat/websocket"
}

gnestor · 2018-09-14T01:11:32Z

I'm bummed that I wasn't able to attend the JupyterCon sprints and work on this! Do we have any updates since then?

juliandolby · 2018-09-14T01:32:44Z

The main update that I have is that code with the LSP server in a settings pane is committed to my branch.

…

On Sep 13, 2018, at 9:11 PM, Grant Nestor ***@***.***> wrote: I'm bummed that I wasn't able to attend the JupyterCon sprints and work on this! Do we have any updates since JupyterCon? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#12 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABk3fpCfV3DKU35QXa2XpMjqDiyvvkOCks5uawJFgaJpZM4U6FTU>.

jasongrout · 2018-09-14T03:19:01Z

Julian, I've just made you a collaborator, which I think means you should be able to merge things into this repo. Thanks again for working on all this!

juliandolby · 2018-09-17T15:27:20Z

Thanks @jasongrout! I decided to get ambitious and try to update the module to use monaco-languageclient-0.9.0 from TypeFox. The good news is that minimal changes make the code compile and link. The bad news is that 'jupyter labextension link' then blows up with errors that I have never seen before.

I am attaching my output logs, in case anyone else has seen errors like this before, and knows what they mean.

My minimal code changes are on the branch lsp-mlc090 in my fork.

yarn_build.txt
yarn_install.txt
link.txt

juliandolby · 2018-09-18T01:37:44Z

A bit of hacking, and I have my updated code working in a Monaco demo, and it gets richer LSP information such as the 'related information'. the display looks as rich as vscode now. and it would all work in Jupyter too, but labextension link seems to hate the vscode engine.

blink1073 · 2018-09-21T10:01:26Z

@juliandolby, I just tried it locally and it installed fine, can you please try jupyter lab clean && jupyter lab build, it looks like the classic broken node_modules problem.

juliandolby · 2018-09-21T10:46:30Z

I still get the problem, even when i try the commands you suggested. I even tried a fresh git clone first to get a clean directory

git clone [email protected]:juliandolby/jupyterlab-monaco jupyterlab-monaco-mlc090
cd jupyterlab-monaco-mlc090/
git checkout lsp-mlc090
jupyter lab clean && jupyter lab build

blink1073 · 2018-09-21T10:50:17Z

What is node -v?

juliandolby · 2018-09-21T12:21:59Z

bash-3.2$ node -v
v8.12.0

blink1073 · 2018-09-21T12:24:16Z

What is your PATH?

juliandolby · 2018-09-21T12:48:53Z

bash-4.4$ echo $PATH 
/Users/dolby/anaconda3/bin:/Users/dolby/.opam/system/bin:/Users/dolby/.rvm/gems/ruby-2.4.1/bin:/Users/dolby/.rvm/gems/ruby-2.4.1@global/bin:/Users/dolby/.rvm/rubies/ruby-2.4.1/bin:/opt/local/bin:/opt/local/sbin:/Users/dolby/.opam/system/bin:/opt/local/bin:/opt/local/sbin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/share/dotnet:/opt/X11/bin:/Library/Frameworks/Mono.framework/Versions/Current/Commands:/Users/dolby/.rvm/bin:/opt/X11/bin:/Users/dolby/.rvm/bin:/Users/dolby/.rvm/bin
bash-4.4$ which node
/opt/local/bin/node
bash-4.4$ which jupyter
/Users/dolby/anaconda3/bin/jupyter
bash-4.4$ which yarn
/opt/local/bin/yarn

blink1073 · 2018-09-21T13:41:57Z

From /Users/dolby/anaconda3/share/jupyter/lab/staging/, what does yarn list --pattern=vscode give?

juliandolby · 2018-09-21T13:46:45Z

I get an error, I think:

bash-3.2$ pwd
/Users/dolby/anaconda3/share/jupyter/lab/staging
bash-3.2$ yarn list --pattern=vscode
yarn list v1.9.4
error No lockfile in this directory. Run `yarn install` to generate one.
info Visit https://yarnpkg.com/en/docs/cli/list for documentation about this command.

blink1073 · 2018-09-21T13:48:08Z

Ahh, I see, the error occurs when yarn is creating the lock file. Do you have any user or system level .npmrc or .yarnrc files?

juliandolby · 2018-09-21T14:13:15Z

There are no such files in my home directory, and I did not create any system ones knowingly.

One thing I notice in the staging area: the vscode module seems to be installed in /Users/dolby/anaconda3/share/jupyter/lab/staging/node_modules/ rather than /Users/dolby/anaconda3/share/jupyter/lab/staging/node_modules/jupyterlab-monaco/node_modules/, even though it is jupyterlab-monaco that asks for vscode. And then the jupyterlab-monaco post-install script is run in the latter and cannot find the install script.

blink1073 · 2018-09-21T14:38:00Z

Wow, this is the problem: ./vscode-base-languageclient/package.json:30: "prepublish": "node ./node_modules/vscode/bin/install && npm run compile", cf TypeFox/monaco-languageclient#89 (comment). yarn is hoisting that package in your case but not in mine, even though we are both using 1.9.4. I'm not sure what can be done. This is highly indicative of how tightly coupled monaco is to vscode still...

juliandolby · 2018-09-21T16:01:45Z

After a bit of searching on the Web, I found a promising-looking 'nohoist' option for package.json and managed to eliminate the first error. I am attaching the latest log of jupyter labextension link where you can see the error of being unable to find the install command goes away. I added the following to my package.json:

 "workspaces": {
      "nohoist": ["vscode"]
  },

It still dies in the final webpack, though, unable to find something else, so I wonder if it makes sense to try adding 'nohoist' in the overall jupyterlab package.json?

juliandolby · 2018-09-21T18:22:47Z

If it works for you, could you create the extension for JupyterLab so that I could test it?

blink1073 · 2018-09-22T08:46:44Z

You can test locally by updating this file: https://github.com/jupyterlab/jupyterlab/blob/master/jupyterlab/staging/package.json, which gets used in you application staging directory.

choldgraf · 2018-09-26T20:22:02Z

Just jumping in here to say thanks @juliandolby and @blink1073 for continuing to push on this <3

juliandolby added 7 commits June 27, 2018 13:13

chnges to import monaco-lsp code into jupyter-monaco

60b0f7d

added a bit more code from the LSP example

e38f2b2

logging of hover

ff8369d

fake test hover

755e674

init message seems to work from Monaco to Java LSP server

eb230c9

latest code, with LSP init messages happening but nothing else

45c0232

minor fixes

8af0ca1

gnestor mentioned this pull request Jul 11, 2018

LSP (language server protocol) integration #14

Closed

Merge github.com:jupyterlab/jupyterlab-monaco into lsp

ac341cd

juliandolby added 2 commits August 2, 2018 12:53

include ISettingRegistry. Not using it yet, though.

25bd75f

use config to find lsp server

23dd7c6

blink1073 mentioned this pull request Aug 5, 2018

File completer jupyterlab/jupyterlab#5049

Merged

Merge github.com:jupyterlab/jupyterlab-monaco into lsp

4b188c5

update to 0.34: merge github.com:jupyterlab/jupyterlab-monaco into lsp

5a51f7a

juliandolby added 2 commits August 21, 2018 18:43

use proper schema file to hold lsp server setting

292d2db

newer version

6453df9

saulshanabrook mentioned this pull request Sep 3, 2018

Adopt the language server protocol jupyterlab/jupyterlab#2163

Closed

new default

7f90a6e

juliandolby added 2 commits September 22, 2018 12:31

remove unused stuff

b491244

new needed stuff

8cb9232

fcollonval mentioned this pull request Nov 4, 2018

Use monaco-languageclient instead of monaco-editor #22

Closed

gnestor mentioned this pull request Jan 15, 2019

Add language server (LSP) support in notebook server and jupyterlab-monaco jupyter/enhancement-proposals#26

Closed

2 tasks

fcollonval closed this Aug 8, 2023

changes to import monaco-lsp code into jupyterlab-monaco #12

changes to import monaco-lsp code into jupyterlab-monaco #12

Conversation

juliandolby commented Jun 27, 2018

dhirschfeld commented Jul 24, 2018

juliandolby commented Jul 24, 2018 • edited Loading

ellisonbg commented Jul 26, 2018

ellisonbg commented Jul 26, 2018

juliandolby commented Jul 26, 2018

juliandolby commented Aug 3, 2018

juliandolby commented Aug 13, 2018

ellisonbg commented Aug 18, 2018

juliandolby commented Aug 18, 2018 • edited Loading

ellisonbg commented Aug 18, 2018 via email

blink1073 commented Aug 18, 2018 via email

blink1073 commented Aug 19, 2018 • edited Loading

juliandolby commented Aug 19, 2018

blink1073 commented Aug 19, 2018

LeanderK commented Aug 26, 2018

juliandolby commented Aug 27, 2018

gnestor commented Sep 14, 2018 • edited Loading

juliandolby commented Sep 14, 2018 via email

jasongrout commented Sep 14, 2018

juliandolby commented Sep 17, 2018 • edited Loading

juliandolby commented Sep 18, 2018

blink1073 commented Sep 21, 2018

juliandolby commented Sep 21, 2018

blink1073 commented Sep 21, 2018

juliandolby commented Sep 21, 2018

blink1073 commented Sep 21, 2018

juliandolby commented Sep 21, 2018

blink1073 commented Sep 21, 2018

juliandolby commented Sep 21, 2018

blink1073 commented Sep 21, 2018

juliandolby commented Sep 21, 2018

blink1073 commented Sep 21, 2018

juliandolby commented Sep 21, 2018

juliandolby commented Sep 21, 2018

blink1073 commented Sep 22, 2018

choldgraf commented Sep 26, 2018

juliandolby commented Jul 24, 2018 •

edited

Loading

juliandolby commented Aug 18, 2018 •

edited

Loading

blink1073 commented Aug 19, 2018 •

edited

Loading

gnestor commented Sep 14, 2018 •

edited

Loading

juliandolby commented Sep 17, 2018 •

edited

Loading