Update tests #53
Update tests #53
Conversation
| launch: { | ||
| headless: process.env.HEADLESS !== "false" | ||
| headless: process.env.HEADLESS !== 'false', | ||
| slowMo: process.env.SLOWMO === 'true' |
There was a problem hiding this comment.
Was definitely useful in seeing what button was being pressed in real-time.
| }, | ||
| // https://github.com/smooth-code/jest-puppeteer/tree/master/packages/jest-dev-server#options | ||
| server: { | ||
| command: "jupyter lab --port 8080 --no-browser", | ||
| command: "jupyter lab --port 8080 --no-browser --LabApp.token=''", |
There was a problem hiding this comment.
One less configuration file.
| "outDir": "build/test", | ||
| "rootDir": "test" | ||
| }, | ||
| "include": ["test/*", "test/**/*"] |
There was a problem hiding this comment.
Yeah probably good call to separate these
There was a problem hiding this comment.
I recognize that, in other worlds (e.g., Go, Ruby), placing tests next to source files is common; in Node.js land, it isn't for reasons of separation of concerns. Plus, UI tests cross file divides and don't fit nicely into the foo.spec.ts paradigm where foo refers to foo.ts, a source file.
| // Load JupyterLab: | ||
| await page.goto('http://localhost:8080/lab?reset'); | ||
|
|
||
| // NOTE: depending on system resource constraints, this may NOT be enough time for JupyterLab to load and get "settled", so to speak. If CI tests begin inexplicably failing due to timeout failures, may want to consider increasing the sleep duration... |
| // Based on from https://yarnpkg.com/en/package/@rws-air/jestscreenshot | ||
|
|
||
| const PuppeteerEnvironment = require("jest-environment-puppeteer"); | ||
| const JestScreenshot = require("@rws-air/jestscreenshot"); | ||
| require("jest-circus"); |
There was a problem hiding this comment.
It's interesting you didn't need this! Not sure why we did, they just had it here.
There was a problem hiding this comment.
This was present in one of the dep documentation examples. I am not sure why it was there. If it was needed, I would disappointed, as it means importing the package has (gasp) side-effects :|.
|
I'm loving the green checkmark |
This PR moves files around to minimize the need to rebuild when updating tests and modifies some of the test commands.