Jsonize NaN and Infinity as strings #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current approach
The treatment of
NaNand(-)Infinityimplemented in f427b2e serialize them asnullto get valid JSON.This raises the following problems:
NaNand(-)Infinitycannot be distinguished from each other once serializedh5py.Emptywhich is alsonullAdded basic support of empty datasets (H5S_NULLshape in HDF5) #79What this PR does
It implements the approach described by @kgryte in #22:
NaNand(-)Infinityare serialized as strings. This allows a front-end consumer to distinguish between the two and use a reviver to parse it to the desired value (e.g.Number.NaNorNumber.POSITIVE_INFINITYin JS).